admin/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-12-07 20:06:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

remoteproc: qcom: q6v5: Fix NULL vs IS_ERR() bug in q6v5_alloc_memory_region()

Browse Source 
The devm_ioremap_resource_wc() function never returns NULL, it returns
error pointers.  Update the checking to match.

Fixes: c70b9d5fdc ("remoteproc: qcom: Use of_reserved_mem_region_* functions for "memory-region"")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/674b32a78563282adeaf3cdf941314a0b8181026.1764427595.git.dan.carpenter@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
This commit is contained in:
Dan Carpenter
2025-11-29 17:51:05 +03:00
committed by Bjorn Andersson
parent e7839f773e
commit cb200e41ed
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/remoteproc/qcom_q6v5_wcss.c
View File

@@ -887,9 +887,9 @@ static int q6v5_alloc_memory_region(struct q6v5_wcss *wcss)
wcss->mem_reloc = res.start;
wcss->mem_size = resource_size(&res);
wcss->mem_region = devm_ioremap_resource_wc(dev, &res);
if (!wcss->mem_region) {
if (IS_ERR(wcss->mem_region)) {
dev_err(dev, "unable to map memory region: %pR\n", &res);
return -EBUSY;
return PTR_ERR(wcss->mem_region);
}
return 0;