admin/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-12-07 20:06:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

gpu: nova-core: remove unnecessary need_riscv, bar parameters

Browse Source 
The need_riscv parameter and its associated RISCV validation logic are
are actually unnecessary for correct operation. Remove it, along with
the now-unused bar parameter as well.

Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Message-ID: <20251025014050.585153-3-jhubbard@nvidia.com>
This commit is contained in:
John Hubbard
2025-10-24 18:40:50 -07:00
committed by Alexandre Courbot
parent 1784fb79d6
commit c58f00b44e
2 changed files with 2 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/gpu/nova-core/falcon.rs
View File

@@ -362,26 +362,7 @@ pub(crate) struct Falcon<E: FalconEngine> {
impl<E: FalconEngine + 'static> Falcon<E> {
/// Create a new falcon instance.
///
/// `need_riscv` is set to `true` if the caller expects the falcon to be a dual falcon/riscv
/// controller.
pub(crate) fn new(
dev: &device::Device,
chipset: Chipset,
bar: &Bar0,
need_riscv: bool,
) -> Result<Self> {
if need_riscv {
let hwcfg2 = regs::NV_PFALCON_FALCON_HWCFG2::read(bar, &E::ID);
if !hwcfg2.riscv() {
dev_err!(
dev,
"riscv support requested on a controller that does not support it\n"
);
return Err(EINVAL);
}
}
pub(crate) fn new(dev: &device::Device, chipset: Chipset) -> Result<Self> {
Ok(Self {
hal: hal::falcon_hal(chipset)?,
dev: dev.into(),

4
drivers/gpu/nova-core/gpu.rs
View File

@@ -213,12 +213,10 @@ impl Gpu {
gsp_falcon: Falcon::new(
pdev.as_ref(),
spec.chipset,
bar,
spec.chipset > Chipset::GA100,
)
.inspect(|falcon| falcon.clear_swgen0_intr(bar))?,
sec2_falcon: Falcon::new(pdev.as_ref(), spec.chipset, bar, true)?,
sec2_falcon: Falcon::new(pdev.as_ref(), spec.chipset)?,
gsp <- Gsp::new(),