admin/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-12-07 20:06:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

fgraph: Make fgraph_no_sleep_time signed

Browse Source 
The variable fgraph_no_sleep_time changed from being a boolean to being a
counter. A check is made to make sure that it never goes below zero. But
the variable being unsigned makes the check always fail even if it does go
below zero.

Make the variable a signed int so that checking it going below zero still
works.

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://patch.msgid.link/20251125104751.4c9c7f28@gandalf.local.home
Fixes: 5abb6ccb58 ("tracing: Have function graph tracer option sleep-time be per instance")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/aR1yRQxDmlfLZzoo@stanley.mountain/
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
This commit is contained in:
Steven Rostedt
2025-11-25 10:47:51 -05:00
committed by Steven Rostedt (Google)
parent bc089c4725
commit ac87b220a6
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
kernel/trace/trace.h
View File

@@ -1113,7 +1113,7 @@ static inline void ftrace_graph_addr_finish(struct fgraph_ops *gops, struct ftra
#endif /* CONFIG_DYNAMIC_FTRACE */
extern unsigned int fgraph_max_depth;
extern unsigned int fgraph_no_sleep_time;
extern int fgraph_no_sleep_time;
extern bool fprofile_no_sleep_time;
static inline bool

2
kernel/trace/trace_functions_graph.c
View File

@@ -20,7 +20,7 @@
static int ftrace_graph_skip_irqs;
/* Do not record function time when task is sleeping */
unsigned int fgraph_no_sleep_time;
int fgraph_no_sleep_time;
struct fgraph_cpu_data {
pid_t last_pid;