admin/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-12-07 20:06:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

usb: typec: intel_pmc_mux: Deduplicate ACPI matching in probe

Browse Source 
There is no need to call acpi_dev_present() followed by
acpi_dev_get_first_match_dev() as they both do the same
with only difference in the returning value. Instead,
call the latter and check its result.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20230102202933.15968-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Andy Shevchenko
2023-01-02 22:29:33 +02:00
committed by Greg Kroah-Hartman
parent c3194949ae
commit 8b9c6ab156
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/usb/typec/mux/intel_pmc_mux.c
View File

@@ -602,16 +602,15 @@ static int pmc_usb_probe_iom(struct pmc_usb *pmc)
int ret;
for (dev_id = &iom_acpi_ids[0]; dev_id->id[0]; dev_id++) {
if (acpi_dev_present(dev_id->id, NULL, -1)) {
pmc->iom_port_status_offset = (u32)dev_id->driver_data;
adev = acpi_dev_get_first_match_dev(dev_id->id, NULL, -1);
adev = acpi_dev_get_first_match_dev(dev_id->id, NULL, -1);
if (adev)
break;
}
}
if (!adev)
return -ENODEV;
pmc->iom_port_status_offset = (u32)dev_id->driver_data;
INIT_LIST_HEAD(&resource_list);
ret = acpi_dev_get_memory_resources(adev, &resource_list);
if (ret < 0) {