admin/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-12-07 20:06:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

drm/xe/debugfs: Update xe_tuning_dump signature

Browse Source 
Our debugfs helper xe_gt_debugfs_show_with_rpm() expects print()
functions to return int. New signature allows us to drop wrapper.

While around, print additional separation lines using puts() to
avoid output with leading \n which might confuse some printers.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://lore.kernel.org/r/20250923211613.193347-4-michal.wajdeczko@intel.com
This commit is contained in:
Michal Wajdeczko
2025-09-23 23:16:11 +02:00
parent d06e0c33f3
commit 8980530abf
3 changed files with 16 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/gpu/drm/xe/xe_gt_debugfs.c
View File

@@ -167,12 +167,6 @@ static int register_save_restore(struct xe_gt *gt, struct drm_printer *p)
return 0;
}
static int tunings(struct xe_gt *gt, struct drm_printer *p)
{
xe_tuning_dump(gt, p);
return 0;
}
static int pat(struct xe_gt *gt, struct drm_printer *p)
{
xe_pat_dump(gt, p);
@@ -231,7 +225,7 @@ static const struct drm_info_list vf_safe_debugfs_list[] = {
{ "register-save-restore",
.show = xe_gt_debugfs_show_with_rpm, .data = register_save_restore },
{ "workarounds", .show = xe_gt_debugfs_show_with_rpm, .data = xe_wa_gt_dump },
{ "tunings", .show = xe_gt_debugfs_show_with_rpm, .data = tunings },
{ "tunings", .show = xe_gt_debugfs_show_with_rpm, .data = xe_tuning_dump },
{ "default_lrc_rcs", .show = xe_gt_debugfs_show_with_rpm, .data = rcs_default_lrc },
{ "default_lrc_ccs", .show = xe_gt_debugfs_show_with_rpm, .data = ccs_default_lrc },
{ "default_lrc_bcs", .show = xe_gt_debugfs_show_with_rpm, .data = bcs_default_lrc },

17
drivers/gpu/drm/xe/xe_tuning.c
View File

@@ -214,7 +214,14 @@ void xe_tuning_process_lrc(struct xe_hw_engine *hwe)
xe_rtp_process_to_sr(&ctx, lrc_tunings, ARRAY_SIZE(lrc_tunings), &hwe->reg_lrc);
}
void xe_tuning_dump(struct xe_gt *gt, struct drm_printer *p)
/**
* xe_tuning_dump() - Dump GT tuning info into a drm printer.
* @gt: the &xe_gt
* @p: the &drm_printer
*
* Return: always 0.
*/
int xe_tuning_dump(struct xe_gt *gt, struct drm_printer *p)
{
size_t idx;
@@ -222,11 +229,15 @@ void xe_tuning_dump(struct xe_gt *gt, struct drm_printer *p)
for_each_set_bit(idx, gt->tuning_active.gt, ARRAY_SIZE(gt_tunings))
drm_printf_indent(p, 1, "%s\n", gt_tunings[idx].name);
drm_printf(p, "\nEngine Tunings\n");
drm_puts(p, "\n");
drm_printf(p, "Engine Tunings\n");
for_each_set_bit(idx, gt->tuning_active.engine, ARRAY_SIZE(engine_tunings))
drm_printf_indent(p, 1, "%s\n", engine_tunings[idx].name);
drm_printf(p, "\nLRC Tunings\n");
drm_puts(p, "\n");
drm_printf(p, "LRC Tunings\n");
for_each_set_bit(idx, gt->tuning_active.lrc, ARRAY_SIZE(lrc_tunings))
drm_printf_indent(p, 1, "%s\n", lrc_tunings[idx].name);
return 0;
}

2
drivers/gpu/drm/xe/xe_tuning.h
View File

@@ -14,6 +14,6 @@ int xe_tuning_init(struct xe_gt *gt);
void xe_tuning_process_gt(struct xe_gt *gt);
void xe_tuning_process_engine(struct xe_hw_engine *hwe);
void xe_tuning_process_lrc(struct xe_hw_engine *hwe);
void xe_tuning_dump(struct xe_gt *gt, struct drm_printer *p);
int xe_tuning_dump(struct xe_gt *gt, struct drm_printer *p);
#endif