drm/i915: add note on VLV/CHV hpll_freq and czclk_freq caching

The caching at the initial read is a bit fragile in case, say, a further
refactoring starts reading the frequencies at a time where it's not
possible. Add a note about it.

Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://lore.kernel.org/r/20250917135200.1932903-1-jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
This commit is contained in:
Jani Nikula
2025-09-17 16:52:00 +03:00
parent fcf2af765c
commit 7a356ee5cf

View File

@@ -8,6 +8,13 @@
#include "vlv_clock.h"
#include "vlv_sideband.h"
/*
* FIXME: The caching of hpll_freq and czclk_freq relies on the first calls
* occurring at a time when they can actually be read. This appears to be the
* case, but is somewhat fragile. Make the initialization explicit at a point
* where they can be reliably read.
*/
/* returns HPLL frequency in kHz */
int vlv_clock_get_hpll_vco(struct drm_device *drm)
{