mirror of
https://github.com/torvalds/linux.git
synced 2025-12-07 20:06:24 +00:00
drm/panthor: Fix UAF race between device unplug and FW event processing
The function panthor_fw_unplug() will free the FW memory sections.
The problem is that there could still be pending FW events which are yet
not handled at this point. process_fw_events_work() can in this case try
to access said freed memory.
Simply call disable_work_sync() to both drain and prevent future
invocation of process_fw_events_work().
Signed-off-by: Ketil Johnsen <ketil.johnsen@arm.com>
Fixes: de85488138 ("drm/panthor: Add the scheduler logical block")
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Link: https://patch.msgid.link/20251027140217.121274-1-ketil.johnsen@arm.com
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
This commit is contained in:
committed by
Liviu Dudau
parent
94a6d20fea
commit
7051f6ba96
@@ -3878,6 +3878,7 @@ void panthor_sched_unplug(struct panthor_device *ptdev)
|
||||
struct panthor_scheduler *sched = ptdev->scheduler;
|
||||
|
||||
cancel_delayed_work_sync(&sched->tick_work);
|
||||
disable_work_sync(&sched->fw_events_work);
|
||||
|
||||
mutex_lock(&sched->lock);
|
||||
if (sched->pm.has_ref) {
|
||||
|
||||
Reference in New Issue
Block a user