admin/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-12-07 20:06:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

net: stmmac: lpc18xx: validate phy_intf_sel

Browse Source 
Validate the phy_intf_sel value rather than the PHY interface mode.
This will allow us to transition to the ->set_phy_intf_sel() method.
Note that this will allow GMII as well as MII as the phy_intf_sel
value is the same for both.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1vGy5P-0000000DhQJ-0Oi3@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Russell King (Oracle)
2025-11-06 11:23:27 +00:00
committed by Jakub Kicinski
parent 9882f12194
commit 4bad421924
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c
View File

@@ -47,14 +47,13 @@ static int lpc18xx_dwmac_probe(struct platform_device *pdev)
return PTR_ERR(reg);
}
if (plat_dat->phy_interface != PHY_INTERFACE_MODE_MII &&
plat_dat->phy_interface != PHY_INTERFACE_MODE_RMII) {
ethmode = stmmac_get_phy_intf_sel(plat_dat->phy_interface);
if (ethmode != PHY_INTF_SEL_GMII_MII &&
ethmode != PHY_INTF_SEL_RMII) {
dev_err(&pdev->dev, "Only MII and RMII mode supported\n");
return -EINVAL;
}
ethmode = stmmac_get_phy_intf_sel(plat_dat->phy_interface);
regmap_update_bits(reg, LPC18XX_CREG_CREG6,
LPC18XX_CREG_CREG6_ETHMODE_MASK, ethmode);