admin/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-12-07 20:06:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

drm/log: Do not hold lock across drm_client_release()

Browse Source 
When calling drm_client_release(), the client is already quiescent.
Internal locks should therefore be dropped before the caller releases
the client.

In the case of the DRM log, concurrency originates from the console or
from client events. The console has been unregistered in the previous
line. The caller of the unregister callback, drm_log_client_unregister(),
holds clientlist_mutex from struct drm_device to protect against concurrent
client events. It is therefore safe to release the client without holding
locks.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>>
Link: https://lore.kernel.org/r/20251009132006.45834-3-tzimmermann@suse.de
This commit is contained in:
Thomas Zimmermann
2025-10-09 15:16:29 +02:00
parent a16f6ba43d
commit 33ba21e9e1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/clients/drm_log.c
View File

@@ -302,8 +302,8 @@ static void drm_log_client_unregister(struct drm_client_dev *client)
mutex_lock(&dlog->lock);
drm_log_free_scanout(client);
drm_client_release(client);
mutex_unlock(&dlog->lock);
drm_client_release(client);
kfree(dlog);
drm_dbg(dev, "Unregistered with drm log\n");
}