admin/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-12-07 20:06:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

of: unittest: Drop if blocks with always false condition

Browse Source 
unittest_gpio_remove() is only called after unittest_gpio_probe() completed
successfully. In this case driver data was set to a non-NULL value and so
platform_get_drvdata() never returns NULL.

Also note that the compiler might optimize away this check anyhow as
devptr was already dereferenced for the dev_dbg call above.

Drop this if block.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230319100620.295849-3-u.kleine-koenig@pengutronix.de
Signed-off-by: Rob Herring <robh@kernel.org>
This commit is contained in:
Uwe Kleine-König
2023-03-19 11:06:19 +01:00
committed by Rob Herring
parent 5cdade2d77
commit 13cd9ac670
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/of/unittest.c
View File

@@ -1633,9 +1633,6 @@ static int unittest_gpio_remove(struct platform_device *pdev)
dev_dbg(dev, "%s for node @%pfw\n", __func__, devptr->chip.fwnode);
if (!devptr)
return -EINVAL;
if (devptr->chip.base != -1)
gpiochip_remove(&devptr->chip);