admin/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-12-07 20:06:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

staging: gpib: fmh: Handle gpib_register_driver() errors

Browse Source 
The function gpib_register_driver() can fail, resulting in a
semi-registered module and does not return an error value if it
fails.

Unregister the previous platform driver, pci and gpib registering
functions if subsequent gpib_register_driver() fail and return the
error value. Add pr_err() statements indicating the fail and also the
error value.

Signed-off-by: Nihar Chaithanya <niharchaithanya@gmail.com>
Link: https://lore.kernel.org/r/20241230185633.175690-8-niharchaithanya@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Nihar Chaithanya
2024-12-31 00:26:27 +05:30
committed by Greg Kroah-Hartman
parent cf95c0c4e0
commit 10ca8c3b51
1 changed files with 39 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
drivers/staging/gpib/fmh_gpib/fmh_gpib.c
View File

@@ -1691,23 +1691,54 @@ static int __init fmh_gpib_init_module(void)
result = platform_driver_register(&fmh_gpib_platform_driver);
if (result) {
pr_err("fmh_gpib: platform_driver_register failed!\n");
pr_err("fmh_gpib: platform_driver_register failed: error = %d\n", result);
return result;
}
result = pci_register_driver(&fmh_gpib_pci_driver);
if (result) {
pr_err("fmh_gpib: pci_driver_register failed!\n");
return result;
pr_err("fmh_gpib: pci_register_driver failed: error = %d\n", result);
goto err_pci_driver;
}
gpib_register_driver(&fmh_gpib_unaccel_interface, THIS_MODULE);
gpib_register_driver(&fmh_gpib_interface, THIS_MODULE);
gpib_register_driver(&fmh_gpib_pci_unaccel_interface, THIS_MODULE);
gpib_register_driver(&fmh_gpib_pci_interface, THIS_MODULE);
result = gpib_register_driver(&fmh_gpib_unaccel_interface, THIS_MODULE);
if (result) {
pr_err("fmh_gpib: gpib_register_driver failed: error = %d\n", result);
goto err_unaccel;
}
result = gpib_register_driver(&fmh_gpib_interface, THIS_MODULE);
if (result) {
pr_err("fmh_gpib: gpib_register_driver failed: error = %d\n", result);
goto err_interface;
}
result = gpib_register_driver(&fmh_gpib_pci_unaccel_interface, THIS_MODULE);
if (result) {
pr_err("fmh_gpib: gpib_register_driver failed: error = %d\n", result);
goto err_pci_unaccel;
}
result = gpib_register_driver(&fmh_gpib_pci_interface, THIS_MODULE);
if (result) {
pr_err("fmh_gpib: gpib_register_driver failed: error = %d\n", result);
goto err_pci;
}
pr_info("fmh_gpib\n");
return 0;
err_pci:
gpib_unregister_driver(&fmh_gpib_pci_unaccel_interface);
err_pci_unaccel:
gpib_unregister_driver(&fmh_gpib_interface);
err_interface:
gpib_unregister_driver(&fmh_gpib_unaccel_interface);
err_unaccel:
pci_unregister_driver(&fmh_gpib_pci_driver);
err_pci_driver:
platform_driver_unregister(&fmh_gpib_platform_driver);
return result;
}
static void __exit fmh_gpib_exit_module(void)