mirror of
https://github.com/torvalds/linux.git
synced 2025-12-07 20:06:24 +00:00
With the introduction of clone3 in commit 7f192e3cd3 ("fork: add
clone3") the effective bit width of clone_flags on all architectures was
increased from 32-bit to 64-bit, with a new type of u64 for the flags.
However, for most consumers of clone_flags the interface was not
changed from the previous type of unsigned long.
While this works fine as long as none of the new 64-bit flag bits
(CLONE_CLEAR_SIGHAND and CLONE_INTO_CGROUP) are evaluated, this is still
undesirable in terms of the principle of least surprise.
Thus, this commit fixes all relevant interfaces of callees to
sys_clone3/copy_process (excluding the architecture-specific
copy_thread) to consistently pass clone_flags as u64, so that
no truncation to 32-bit integers occurs on 32-bit architectures.
Signed-off-by: Simon Schuster <schuster.simon@siemens-energy.com>
Link: https://lore.kernel.org/20250901-nios2-implement-clone3-v2-2-53fcf5577d57@siemens-energy.com
Acked-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Christian Brauner <brauner@kernel.org>
97 lines
2.3 KiB
C
97 lines
2.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#undef TRACE_SYSTEM
|
|
#define TRACE_SYSTEM task
|
|
|
|
#if !defined(_TRACE_TASK_H) || defined(TRACE_HEADER_MULTI_READ)
|
|
#define _TRACE_TASK_H
|
|
#include <linux/tracepoint.h>
|
|
|
|
TRACE_EVENT(task_newtask,
|
|
|
|
TP_PROTO(struct task_struct *task, u64 clone_flags),
|
|
|
|
TP_ARGS(task, clone_flags),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( pid_t, pid)
|
|
__array( char, comm, TASK_COMM_LEN)
|
|
__field( u64, clone_flags)
|
|
__field( short, oom_score_adj)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->pid = task->pid;
|
|
memcpy(__entry->comm, task->comm, TASK_COMM_LEN);
|
|
__entry->clone_flags = clone_flags;
|
|
__entry->oom_score_adj = task->signal->oom_score_adj;
|
|
),
|
|
|
|
TP_printk("pid=%d comm=%s clone_flags=%llx oom_score_adj=%hd",
|
|
__entry->pid, __entry->comm,
|
|
__entry->clone_flags, __entry->oom_score_adj)
|
|
);
|
|
|
|
TRACE_EVENT(task_rename,
|
|
|
|
TP_PROTO(struct task_struct *task, const char *comm),
|
|
|
|
TP_ARGS(task, comm),
|
|
|
|
TP_STRUCT__entry(
|
|
__array( char, oldcomm, TASK_COMM_LEN)
|
|
__array( char, newcomm, TASK_COMM_LEN)
|
|
__field( short, oom_score_adj)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
memcpy(entry->oldcomm, task->comm, TASK_COMM_LEN);
|
|
strscpy(entry->newcomm, comm, TASK_COMM_LEN);
|
|
__entry->oom_score_adj = task->signal->oom_score_adj;
|
|
),
|
|
|
|
TP_printk("oldcomm=%s newcomm=%s oom_score_adj=%hd",
|
|
__entry->oldcomm, __entry->newcomm, __entry->oom_score_adj)
|
|
);
|
|
|
|
/**
|
|
* task_prctl_unknown - called on unknown prctl() option
|
|
* @option: option passed
|
|
* @arg2: arg2 passed
|
|
* @arg3: arg3 passed
|
|
* @arg4: arg4 passed
|
|
* @arg5: arg5 passed
|
|
*
|
|
* Called on an unknown prctl() option.
|
|
*/
|
|
TRACE_EVENT(task_prctl_unknown,
|
|
|
|
TP_PROTO(int option, unsigned long arg2, unsigned long arg3,
|
|
unsigned long arg4, unsigned long arg5),
|
|
|
|
TP_ARGS(option, arg2, arg3, arg4, arg5),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( int, option)
|
|
__field( unsigned long, arg2)
|
|
__field( unsigned long, arg3)
|
|
__field( unsigned long, arg4)
|
|
__field( unsigned long, arg5)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->option = option;
|
|
__entry->arg2 = arg2;
|
|
__entry->arg3 = arg3;
|
|
__entry->arg4 = arg4;
|
|
__entry->arg5 = arg5;
|
|
),
|
|
|
|
TP_printk("option=%d arg2=%ld arg3=%ld arg4=%ld arg5=%ld",
|
|
__entry->option, __entry->arg2, __entry->arg3, __entry->arg4, __entry->arg5)
|
|
);
|
|
|
|
#endif
|
|
|
|
/* This part must be outside protection */
|
|
#include <trace/define_trace.h>
|