admin/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-12-07 20:06:24 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
cb1513db7a6ed82d22853608d78bbf72ad8c67c1
linux/net/ipv4
History
Eric Dumazet 6de1dec1c1 udp: do not use skb_release_head_state() before skb_attempt_defer_free() 
Michal reported and bisected an issue after recent adoption
of skb_attempt_defer_free() in UDP.

The issue here is that skb_release_head_state() is called twice per skb,
one time from skb_consume_udp(), then a second time from skb_defer_free_flush()
and napi_consume_skb().

As Sabrina suggested, remove skb_release_head_state() call from
skb_consume_udp().

Add a DEBUG_NET_WARN_ON_ONCE(skb_nfct(skb)) in skb_attempt_defer_free()

Many thanks to Michal, Sabrina, Paolo and Florian for their help.

Fixes: 6471658dc6 ("udp: use skb_attempt_defer_free()")
Reported-and-bisected-by: Michal Kubecek <mkubecek@suse.cz>
Closes: https://lore.kernel.org/netdev/gpjh4lrotyephiqpuldtxxizrsg6job7cvhiqrw72saz2ubs3h@g6fgbvexgl3r/
Signed-off-by: Eric Dumazet <edumazet@google.com>
Tested-by: Michal Kubecek <mkubecek@suse.cz>
Cc: Sabrina Dubroca <sd@queasysnail.net>
Cc: Florian Westphal <fw@strlen.de>
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Link: https://patch.msgid.link/20251015052715.4140493-1-edumazet@google.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
2025-10-16 16:03:07 +02:00
..
netfilter
netfilter: nf_reject: don't reply to icmp error messages
2025-09-11 15:40:55 +02:00
af_inet.c
net: gro: remove unnecessary df checks
2025-09-25 12:42:49 +02:00
ah4.c
net: fill in MODULE_DESCRIPTION()s for ipv4 modules
2024-02-09 14:12:02 -08:00
arp.c
net: set net.core.rmem_max and net.core.wmem_max to 4 MB
2025-08-20 19:35:00 -07:00
bpf_tcp_ca.c
tcp: Pass flags to __tcp_send_ack
2025-03-17 13:56:38 +00:00
cipso_ipv4.c
ipv4: icmp: Pass IPv4 control block structure as an argument to __icmp_send()
2025-09-11 12:22:38 +02:00
datagram.c
net: dst: annotate data-races around dst->obsolete
2025-07-02 14:32:29 -07:00
devinet.c
ipv4: Fix NULL vs error pointer check in inet_blackhole_dev_init()
2025-09-03 16:58:44 -07:00
esp4_offload.c
xfrm: Add an inbound percpu state cache.
2024-10-29 11:56:18 +01:00
esp4.c
tcp: Don't pass hashinfo to socket lookup helpers.
2025-08-25 17:53:35 -07:00
fib_frontend.c
ipv4: Convert ->flowi4_tos to dscp_t.
2025-08-26 17:34:31 -07:00
fib_lookup.h
…
fib_notifier.c
net: do not acquire rtnl in fib_seq_sum()
2024-10-11 15:35:05 -07:00
fib_rules.c
ipv4: Convert ->flowi4_tos to dscp_t.
2025-08-26 17:34:31 -07:00
fib_semantics.c
net: s/dev_get_flags/netif_get_flags/
2025-07-18 17:27:47 -07:00
fib_trie.c
ipv4: fib: Move fib_valid_key_len() to rtm_to_fib_config().
2025-03-03 15:04:11 -08:00
fou_bpf.c
ip_tunnel: convert __be16 tunnel flags to bitmaps
2024-04-01 10:49:28 +01:00
fou_core.c
net: gro: remove is_ipv6 from napi_gro_cb
2025-09-25 12:42:49 +02:00
fou_nl.c
netlink: specs: fou: change local-v6/peer-v6 check
2025-09-03 15:16:49 -07:00
fou_nl.h
net: ynl: prefix uAPI header include with uapi/
2023-05-26 10:30:14 +01:00
gre_demux.c
net: ip_gre: Fix spelling mistake "demultiplexor" -> "demultiplexer"
2025-04-24 18:20:40 -07:00
gre_offload.c
net: gro: rename skb_gro_header_hard()
2024-03-05 13:30:11 +01:00
icmp.c
ipv4: icmp: Fix source IP derivation in presence of VRFs
2025-09-11 12:22:38 +02:00
igmp_internal.h
netlink: support dumping IPv4 multicast addresses
2025-02-11 11:26:53 +01:00
igmp.c
ipv4: adopt dst_dev, skb_dst_dev and skb_dst_dev_net[_rcu]
2025-07-02 14:32:30 -07:00
inet_connection_sock.c
tcp: Update bind bucket state on port release
2025-09-23 10:12:15 +02:00
inet_diag.c
inet_diag: avoid cache line misses in inet_diag_bc_sk()
2025-08-29 19:29:24 -07:00
inet_fragment.c
net: replace use of system_wq with system_percpu_wq
2025-09-22 17:40:30 -07:00
inet_hashtables.c
tcp: Update bind bucket state on port release
2025-09-23 10:12:15 +02:00
inet_timewait_sock.c
Merge tag 'net-next-6.18' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2025-10-02 15:17:01 -07:00
inetpeer.c
inetpeer: use EXPORT_IPV6_MOD[_GPL]()
2025-02-14 13:09:39 -08:00
ip_forward.c
net: fix IPSTATS_MIB_OUTFORWDATAGRAMS increment after fragment check
2023-10-13 09:58:45 -07:00
ip_fragment.c
ipv4: start using dst_dev_rcu()
2025-08-29 19:36:32 -07:00
ip_gre.c
ipv4: Convert ->flowi4_tos to dscp_t.
2025-08-26 17:34:31 -07:00
ip_input.c
net: ipv4: convert ip_rcv_options to drop reasons
2025-09-19 17:35:52 -07:00
ip_options.c
net: Switch to skb_dstref_steal/skb_dstref_restore for ip_route_input callers
2025-08-19 17:54:35 -07:00
ip_output.c
net: psp: don't assume reply skbs will have a socket
2025-10-03 10:23:50 -07:00
ip_sockglue.c
Merge tag 'net-next-6.14' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2025-01-22 08:28:57 -08:00
ip_tunnel_core.c
tunnels: reset the GSO metadata before reusing the skb
2025-09-09 13:03:33 +02:00
ip_tunnel.c
net/ip6_tunnel: Prevent perpetual tunnel growth
2025-10-13 17:43:46 -07:00
ip_vti.c
ipv4: adopt dst_dev, skb_dst_dev and skb_dst_dev_net[_rcu]
2025-07-02 14:32:30 -07:00
ipcomp.c
xfrm: delete x->tunnel as we delete x
2025-07-08 13:28:27 +02:00
ipconfig.c
net: ipconfig: convert timeouts to secs_to_jiffies()
2025-07-09 19:25:01 -07:00
ipip.c
ipv4: ip_tunnel: Convert ip_tunnel_delete_nets() callers to ->exit_rtnl().
2025-04-14 17:08:42 -07:00
ipmr_base.c
ipmr: do not call mr_mfc_uses_dev() for unres entries
2025-01-23 07:08:13 -08:00
ipmr.c
ipv4: start using dst_dev_rcu()
2025-08-29 19:36:32 -07:00
Kconfig
net: Retire DCCP socket.
2025-04-11 18:58:10 -07:00
Makefile
bpfilter: remove bpfilter
2024-01-04 10:23:10 -08:00
metrics.c
net: remove NULL-pointer net parameter in ip_metrics_convert
2024-06-05 10:06:00 +01:00
netfilter.c
ipv4: Convert ->flowi4_tos to dscp_t.
2025-08-26 17:34:31 -07:00
netlink.c
…
nexthop.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2025-09-25 11:00:59 -07:00
ping.c
inet: ping: use EXPORT_IPV6_MOD[_GPL]()
2025-09-01 13:15:14 -07:00
proc.c
ipv4: snmp: do not use SNMP_MIB_SENTINEL anymore
2025-09-08 18:06:20 -07:00
protocol.c
…
raw_diag.c
inet_diag: change inet_diag_bc_sk() first argument
2025-08-29 19:29:24 -07:00
raw.c
inet: raw: add drop_counters to raw sockets
2025-08-28 13:14:50 +02:00
route.c
ipv4: icmp: Pass IPv4 control block structure as an argument to __icmp_send()
2025-09-11 12:22:38 +02:00
syncookies.c
tcp: accecn: AccECN negotiation
2025-09-18 08:47:51 +02:00
sysctl_net_ipv4.c
tcp: accecn: AccECN option send control
2025-09-18 08:47:52 +02:00
tcp_ao.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2025-09-18 11:26:06 -07:00
tcp_bbr.c
tcp: Add new args for cong_control in tcp_congestion_ops
2024-05-02 16:26:56 -07:00
tcp_bic.c
…
tcp_bpf.c
tcp_bpf: Call sk_msg_free() when tcp_bpf_send_verdict() fails to allocate psock->cork.
2025-09-10 06:53:56 -07:00
tcp_cdg.c
tcp: cdg: remove redundant __GFP_NOWARN
2025-08-12 14:05:43 -07:00
tcp_cong.c
tcp: only release congestion control if it has been initialized
2024-10-31 18:22:48 -07:00
tcp_cubic.c
tcp_cubic: fix incorrect HyStart round start detection
2025-01-20 12:26:41 +00:00
tcp_dctcp.c
tcp: helpers for ECN mode handling
2025-03-17 13:54:11 +00:00
tcp_dctcp.h
tcp: Pass flags to __tcp_send_ack
2025-03-17 13:56:38 +00:00
tcp_diag.c
inet_diag: change inet_diag_bc_sk() first argument
2025-08-29 19:29:24 -07:00
tcp_fastopen.c
tcp: use dst_dev_rcu() in tcp_fastopen_active_disable_ofo_check()
2025-08-29 19:36:32 -07:00
tcp_highspeed.c
…
tcp_htcp.c
tcp: Use clamp() in htcp_alpha_update()
2024-08-06 12:16:25 -07:00
tcp_hybla.c
…
tcp_illinois.c
…
tcp_input.c
tcp: Don't call reqsk_fastopen_remove() in tcp_conn_request().
2025-10-06 11:11:20 -07:00
tcp_ipv4.c
net: psp: update the TCP MSS to reflect PSP packet overhead
2025-09-18 12:32:06 +02:00
tcp_lp.c
tcp: rename tcp_time_stamp() to tcp_time_stamp_ts()
2023-10-23 09:35:01 +01:00
tcp_metrics.c
Merge tag 'net-next-6.18' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2025-10-02 15:17:01 -07:00
tcp_minisocks.c
tcp: add datapath logic for PSP with inline key exchange
2025-09-18 12:32:06 +02:00
tcp_nv.c
…
tcp_offload.c
net: gso: restore ids of outer ip headers correctly
2025-09-25 12:42:49 +02:00
tcp_output.c
tcp: fix tcp_tso_should_defer() vs large RTT
2025-10-14 12:21:48 +02:00
tcp_plb.c
…
tcp_rate.c
…
tcp_recovery.c
tcp: update the outdated ref draft-ietf-tcpm-rack
2025-07-08 09:01:52 -07:00
tcp_scalable.c
…
tcp_sigpool.c
net/tcp_sigpool: Use nested-BH locking for sigpool_scratch.
2024-06-24 16:41:22 -07:00
tcp_timer.c
tcp: annotate data-races around icsk->icsk_probes_out
2025-08-25 16:20:59 -07:00
tcp_ulp.c
net/ulp: use consistent error code when blocking ULP
2023-01-19 09:26:16 -08:00
tcp_vegas.c
…
tcp_vegas.h
…
tcp_veno.c
…
tcp_westwood.c
…
tcp_yeah.c
…
tcp.c
tcp: take care of zero tp->window_clamp in tcp_set_rcvlowat()
2025-10-06 13:08:48 -07:00
tunnel4.c
net: fill in MODULE_DESCRIPTION()s for ipv4 modules
2024-02-09 14:12:02 -08:00
udp_bpf.c
bpf, sockmap: Fix an infinite loop error when len is 0 in tcp_bpf_recvmsg_parser()
2023-03-03 17:25:15 +01:00
udp_diag.c
inet_diag: change inet_diag_bc_sk() first argument
2025-08-29 19:29:24 -07:00
udp_impl.h
udp: move udp_memory_allocated into net_aligned_data
2025-07-02 14:22:02 -07:00
udp_offload.c
net: gro: remove is_ipv6 from napi_gro_cb
2025-09-25 12:42:49 +02:00
udp_tunnel_core.c
ipv4: Convert ->flowi4_tos to dscp_t.
2025-08-26 17:34:31 -07:00
udp_tunnel_nic.c
udp_tunnel: use netdev_warn() instead of netdev_WARN()
2025-09-11 19:09:48 -07:00
udp_tunnel_stub.c
…
udp.c
udp: do not use skb_release_head_state() before skb_attempt_defer_free()
2025-10-16 16:03:07 +02:00
udplite.c
udp: move udp_memory_allocated into net_aligned_data
2025-07-02 14:22:02 -07:00
xfrm4_input.c
xfrm: Set transport header to fix UDP GRO handling
2025-07-02 09:19:56 +02:00
xfrm4_output.c
ipv4: adopt dst_dev, skb_dst_dev and skb_dst_dev_net[_rcu]
2025-07-02 14:32:30 -07:00
xfrm4_policy.c
ipv4: Convert ->flowi4_tos to dscp_t.
2025-08-26 17:34:31 -07:00
xfrm4_protocol.c
ipv4: Convert ip_route_input_noref() to dscp_t.
2024-10-03 16:21:21 -07:00
xfrm4_state.c
…
xfrm4_tunnel.c
net: fill in MODULE_DESCRIPTION()s for ipv4 modules
2024-02-09 14:12:02 -08:00