mirror of
https://github.com/torvalds/linux.git
synced 2025-12-07 20:06:24 +00:00
Recently a bug was missed due to the fact that test_tcpbpf_user is not a part of test_progs. In order to prevent similar issues in the future move the test functionality into test_progs. By doing this we can make certain that it is a part of standard testing and will not be overlooked. As a part of moving the functionality into test_progs it is necessary to integrate with the test_progs framework and to drop any redundant code. This patch: 1. Cleans up the include headers 2. Dropped a duplicate definition of bpf_find_map 3. Switched over to using test_progs specific cgroup functions 4. Renamed main to test_tcpbpf_user 5. Dropped return value in favor of CHECK_FAIL to check for errors The general idea is that I wanted to keep the changes as small as possible while moving the file into the test_progs framework. The follow-on patches are meant to clean up the remaining issues such as the use of CHECK_FAIL. Signed-off-by: Alexander Duyck <alexanderduyck@fb.com> Signed-off-by: Alexei Starovoitov <ast@kernel.org> Acked-by: Andrii Nakryiko <andrii@kernel.org> Link: https://lore.kernel.org/bpf/160443928881.1086697.17661359319919165370.stgit@localhost.localdomain
142 lines
3.3 KiB
C
142 lines
3.3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <inttypes.h>
|
|
#include <test_progs.h>
|
|
|
|
#include "test_tcpbpf.h"
|
|
|
|
#define CG_NAME "/tcpbpf-user-test"
|
|
|
|
/* 3 comes from one listening socket + both ends of the connection */
|
|
#define EXPECTED_CLOSE_EVENTS 3
|
|
|
|
#define EXPECT_EQ(expected, actual, fmt) \
|
|
do { \
|
|
if ((expected) != (actual)) { \
|
|
printf(" Value of: " #actual "\n" \
|
|
" Actual: %" fmt "\n" \
|
|
" Expected: %" fmt "\n", \
|
|
(actual), (expected)); \
|
|
ret--; \
|
|
} \
|
|
} while (0)
|
|
|
|
int verify_result(const struct tcpbpf_globals *result)
|
|
{
|
|
__u32 expected_events;
|
|
int ret = 0;
|
|
|
|
expected_events = ((1 << BPF_SOCK_OPS_TIMEOUT_INIT) |
|
|
(1 << BPF_SOCK_OPS_RWND_INIT) |
|
|
(1 << BPF_SOCK_OPS_TCP_CONNECT_CB) |
|
|
(1 << BPF_SOCK_OPS_ACTIVE_ESTABLISHED_CB) |
|
|
(1 << BPF_SOCK_OPS_PASSIVE_ESTABLISHED_CB) |
|
|
(1 << BPF_SOCK_OPS_NEEDS_ECN) |
|
|
(1 << BPF_SOCK_OPS_STATE_CB) |
|
|
(1 << BPF_SOCK_OPS_TCP_LISTEN_CB));
|
|
|
|
EXPECT_EQ(expected_events, result->event_map, "#" PRIx32);
|
|
EXPECT_EQ(501ULL, result->bytes_received, "llu");
|
|
EXPECT_EQ(1002ULL, result->bytes_acked, "llu");
|
|
EXPECT_EQ(1, result->data_segs_in, PRIu32);
|
|
EXPECT_EQ(1, result->data_segs_out, PRIu32);
|
|
EXPECT_EQ(0x80, result->bad_cb_test_rv, PRIu32);
|
|
EXPECT_EQ(0, result->good_cb_test_rv, PRIu32);
|
|
EXPECT_EQ(1, result->num_listen, PRIu32);
|
|
EXPECT_EQ(EXPECTED_CLOSE_EVENTS, result->num_close_events, PRIu32);
|
|
|
|
return ret;
|
|
}
|
|
|
|
int verify_sockopt_result(int sock_map_fd)
|
|
{
|
|
__u32 key = 0;
|
|
int ret = 0;
|
|
int res;
|
|
int rv;
|
|
|
|
/* check setsockopt for SAVE_SYN */
|
|
rv = bpf_map_lookup_elem(sock_map_fd, &key, &res);
|
|
EXPECT_EQ(0, rv, "d");
|
|
EXPECT_EQ(0, res, "d");
|
|
key = 1;
|
|
/* check getsockopt for SAVED_SYN */
|
|
rv = bpf_map_lookup_elem(sock_map_fd, &key, &res);
|
|
EXPECT_EQ(0, rv, "d");
|
|
EXPECT_EQ(1, res, "d");
|
|
return ret;
|
|
}
|
|
|
|
void test_tcpbpf_user(void)
|
|
{
|
|
const char *file = "test_tcpbpf_kern.o";
|
|
int prog_fd, map_fd, sock_map_fd;
|
|
struct tcpbpf_globals g = {0};
|
|
int error = EXIT_FAILURE;
|
|
struct bpf_object *obj;
|
|
int cg_fd = -1;
|
|
int retry = 10;
|
|
__u32 key = 0;
|
|
int rv;
|
|
|
|
cg_fd = test__join_cgroup(CG_NAME);
|
|
if (cg_fd < 0)
|
|
goto err;
|
|
|
|
if (bpf_prog_load(file, BPF_PROG_TYPE_SOCK_OPS, &obj, &prog_fd)) {
|
|
printf("FAILED: load_bpf_file failed for: %s\n", file);
|
|
goto err;
|
|
}
|
|
|
|
rv = bpf_prog_attach(prog_fd, cg_fd, BPF_CGROUP_SOCK_OPS, 0);
|
|
if (rv) {
|
|
printf("FAILED: bpf_prog_attach: %d (%s)\n",
|
|
error, strerror(errno));
|
|
goto err;
|
|
}
|
|
|
|
if (system("./tcp_server.py")) {
|
|
printf("FAILED: TCP server\n");
|
|
goto err;
|
|
}
|
|
|
|
map_fd = bpf_find_map(__func__, obj, "global_map");
|
|
if (map_fd < 0)
|
|
goto err;
|
|
|
|
sock_map_fd = bpf_find_map(__func__, obj, "sockopt_results");
|
|
if (sock_map_fd < 0)
|
|
goto err;
|
|
|
|
retry_lookup:
|
|
rv = bpf_map_lookup_elem(map_fd, &key, &g);
|
|
if (rv != 0) {
|
|
printf("FAILED: bpf_map_lookup_elem returns %d\n", rv);
|
|
goto err;
|
|
}
|
|
|
|
if (g.num_close_events != EXPECTED_CLOSE_EVENTS && retry--) {
|
|
printf("Unexpected number of close events (%d), retrying!\n",
|
|
g.num_close_events);
|
|
usleep(100);
|
|
goto retry_lookup;
|
|
}
|
|
|
|
if (verify_result(&g)) {
|
|
printf("FAILED: Wrong stats\n");
|
|
goto err;
|
|
}
|
|
|
|
if (verify_sockopt_result(sock_map_fd)) {
|
|
printf("FAILED: Wrong sockopt stats\n");
|
|
goto err;
|
|
}
|
|
|
|
error = 0;
|
|
err:
|
|
bpf_prog_detach(cg_fd, BPF_CGROUP_SOCK_OPS);
|
|
if (cg_fd != -1)
|
|
close(cg_fd);
|
|
|
|
CHECK_FAIL(error);
|
|
}
|