mirror of
https://github.com/torvalds/linux.git
synced 2025-12-07 20:06:24 +00:00
0242623384
The driver model defines the lifetime of the private data stored in (and owned by) a bus device to be valid from when the driver is bound to a device (i.e. from successful probe()) until the driver is unbound from the device. This is already taken care of by the Rust implementation of the driver model. However, we still ask drivers to return a Result<Pin<KBox<Self>>> from probe(). Unlike in C, where we do not have the concept of initializers, but rather deal with uninitialized memory, drivers can just return an impl PinInit<Self, Error> instead. This contributes to more clarity to the fact that a driver returns it's device private data in probe() and the Rust driver model owns the data, manages the lifetime and - considering the lifetime - provides (safe) accessors for the driver. Hence, let probe() functions return an impl PinInit<Self, Error> instead of Result<Pin<KBox<Self>>>. Reviewed-by: Alice Ryhl <aliceryhl@google.com> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Danilo Krummrich <dakr@kernel.org>
72 lines
1.9 KiB
Rust
72 lines
1.9 KiB
Rust
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
use kernel::{
|
|
auxiliary, c_str, device::Core, drm, drm::gem, drm::ioctl, prelude::*, sync::aref::ARef,
|
|
};
|
|
|
|
use crate::file::File;
|
|
use crate::gem::NovaObject;
|
|
|
|
pub(crate) struct NovaDriver {
|
|
#[expect(unused)]
|
|
drm: ARef<drm::Device<Self>>,
|
|
}
|
|
|
|
/// Convienence type alias for the DRM device type for this driver
|
|
pub(crate) type NovaDevice = drm::Device<NovaDriver>;
|
|
|
|
#[pin_data]
|
|
pub(crate) struct NovaData {
|
|
pub(crate) adev: ARef<auxiliary::Device>,
|
|
}
|
|
|
|
const INFO: drm::DriverInfo = drm::DriverInfo {
|
|
major: 0,
|
|
minor: 0,
|
|
patchlevel: 0,
|
|
name: c_str!("nova"),
|
|
desc: c_str!("Nvidia Graphics"),
|
|
};
|
|
|
|
const NOVA_CORE_MODULE_NAME: &CStr = c_str!("NovaCore");
|
|
const AUXILIARY_NAME: &CStr = c_str!("nova-drm");
|
|
|
|
kernel::auxiliary_device_table!(
|
|
AUX_TABLE,
|
|
MODULE_AUX_TABLE,
|
|
<NovaDriver as auxiliary::Driver>::IdInfo,
|
|
[(
|
|
auxiliary::DeviceId::new(NOVA_CORE_MODULE_NAME, AUXILIARY_NAME),
|
|
()
|
|
)]
|
|
);
|
|
|
|
impl auxiliary::Driver for NovaDriver {
|
|
type IdInfo = ();
|
|
const ID_TABLE: auxiliary::IdTable<Self::IdInfo> = &AUX_TABLE;
|
|
|
|
fn probe(adev: &auxiliary::Device<Core>, _info: &Self::IdInfo) -> impl PinInit<Self, Error> {
|
|
let data = try_pin_init!(NovaData { adev: adev.into() });
|
|
|
|
let drm = drm::Device::<Self>::new(adev.as_ref(), data)?;
|
|
drm::Registration::new_foreign_owned(&drm, adev.as_ref(), 0)?;
|
|
|
|
Ok(Self { drm })
|
|
}
|
|
}
|
|
|
|
#[vtable]
|
|
impl drm::Driver for NovaDriver {
|
|
type Data = NovaData;
|
|
type File = File;
|
|
type Object = gem::Object<NovaObject>;
|
|
|
|
const INFO: drm::DriverInfo = INFO;
|
|
|
|
kernel::declare_drm_ioctls! {
|
|
(NOVA_GETPARAM, drm_nova_getparam, ioctl::RENDER_ALLOW, File::get_param),
|
|
(NOVA_GEM_CREATE, drm_nova_gem_create, ioctl::AUTH | ioctl::RENDER_ALLOW, File::gem_create),
|
|
(NOVA_GEM_INFO, drm_nova_gem_info, ioctl::AUTH | ioctl::RENDER_ALLOW, File::gem_info),
|
|
}
|
|
}
|