Mikulas Patocka 00a9d699bc
framebuffer: fix cfb_copyarea ...
The function cfb_copyarea is buggy when the copy operation is not aligned on
long boundary (4 bytes on 32-bit machines, 8 bytes on 64-bit machines).
How to reproduce:
- use x86-64 machine
- use a framebuffer driver without acceleration (for example uvesafb)
- set the framebuffer to 8-bit depth
(for example fbset -a 1024x768-60 -depth 8)
- load a font with character width that is not a multiple of 8 pixels
note: the console-tools package cannot load a font that has
width different from 8 pixels. You need to install the packages
"kbd" and "console-terminus" and use the program "setfont" to
set font width (for example: setfont Uni2-Terminus20x10)
- move some text left and right on the bash command line and you get a
screen corruption
To expose more bugs, put this line to the end of uvesafb_init_info:
info->flags |= FBINFO_HWACCEL_COPYAREA | FBINFO_READS_FAST;
- Now framebuffer console will use cfb_copyarea for console scrolling.
You get a screen corruption when console is scrolled.
This patch is a rewrite of cfb_copyarea. It fixes the bugs, with this
patch, console scrolling in 8-bit depth with a font width that is not a
multiple of 8 pixels works fine.
The cfb_copyarea code was very buggy and it looks like it was written
and never tried with non-8-pixel font.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com >
Cc: stable@vger.kernel.org
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com >
2014-02-11 15:01:04 +02:00
2014-01-23 16:36:55 -08:00
2014-01-30 16:56:54 -08:00
2014-02-11 14:16:22 +02:00
2013-11-16 12:45:55 -08:00
2013-10-29 12:53:07 +02:00
2014-01-17 10:57:50 +02:00
2013-09-19 13:30:07 +03:00
2013-11-26 16:40:14 +02:00
2014-01-17 10:57:49 +02:00
2014-02-11 15:01:04 +02:00
2013-09-26 13:49:09 +03:00
2013-10-29 12:53:07 +02:00
2014-01-17 10:57:48 +02:00
2013-08-06 11:18:02 -07:00
2014-01-17 10:57:39 +02:00
2013-09-20 12:22:01 +03:00
2014-01-29 20:49:12 -08:00
2014-01-17 10:57:39 +02:00
2013-09-19 13:30:09 +03:00
2013-11-14 14:44:20 +09:00
2014-01-17 10:57:40 +02:00
2013-01-24 08:59:44 +01:00
2013-10-29 12:53:07 +02:00
2013-11-13 12:09:03 +09:00
2013-09-11 15:56:22 -07:00
2013-11-14 14:44:20 +09:00
2013-11-26 11:09:07 +01:00
2013-10-29 12:53:07 +02:00
2013-12-21 10:06:10 -07:00
2014-01-17 10:57:38 +02:00
2013-10-29 12:53:07 +02:00
2013-12-04 10:48:12 +02:00
2013-11-14 14:44:20 +09:00
2013-11-14 14:44:20 +09:00
2013-04-30 09:36:50 -07:00
2013-04-04 13:08:06 +03:00
2013-04-04 13:08:06 +03:00
2013-09-30 10:51:09 +03:00
2013-01-03 15:57:01 -08:00
2013-04-09 14:13:32 -04:00
2013-06-26 16:16:26 +03:00
2013-09-30 10:51:08 +03:00
2013-10-29 12:53:07 +02:00
2013-09-26 13:49:22 +03:00
2013-10-29 12:53:07 +02:00
2014-02-11 15:01:04 +02:00
2013-10-30 13:34:52 +02:00
2013-09-26 13:49:23 +03:00
2013-10-30 13:34:52 +02:00
2013-10-30 13:34:52 +02:00
2013-01-03 15:57:01 -08:00
2013-11-26 11:09:07 +01:00
2013-02-14 15:14:32 -08:00
2013-10-29 12:53:07 +02:00
2013-10-29 12:53:07 +02:00
2013-11-14 14:44:20 +09:00
2013-10-30 13:36:48 +02:00
2013-01-24 09:03:04 +01:00
2013-01-03 15:57:01 -08:00
2013-10-29 12:53:07 +02:00
2013-09-20 12:22:02 +03:00
2013-02-22 23:31:31 -05:00
2012-07-29 12:25:06 +00:00
2013-10-29 12:53:07 +02:00
2013-08-30 11:41:24 +03:00
2014-01-29 20:49:12 -08:00
2013-04-26 09:14:47 +03:00
2013-11-11 15:52:59 +02:00
2013-09-26 13:49:24 +03:00
2013-10-29 12:53:07 +02:00
2013-11-14 14:44:20 +09:00
2013-10-29 12:53:07 +02:00
2013-03-20 16:26:32 +01:00
2013-09-26 13:49:07 +03:00
2013-10-29 12:53:07 +02:00
2013-08-30 08:42:01 +10:00
2013-10-29 12:53:07 +02:00
2013-10-29 12:53:07 +02:00
2013-10-29 12:53:07 +02:00
2013-10-29 12:53:07 +02:00
2013-10-09 12:52:50 +03:00
2013-10-29 12:53:07 +02:00
2013-10-29 12:53:07 +02:00
2013-10-29 12:53:07 +02:00
2013-09-20 12:22:03 +03:00
2013-09-30 10:51:09 +03:00
2014-01-17 10:57:49 +02:00
2013-10-30 13:34:52 +02:00
2013-11-26 11:09:22 +01:00
2014-01-17 10:57:49 +02:00
2013-10-29 12:20:11 +02:00
2014-01-17 10:57:44 +02:00
2014-01-17 10:57:41 +02:00
2013-11-14 14:44:20 +09:00
2013-10-29 12:53:07 +02:00
2012-09-14 11:18:59 +02:00
2014-01-17 10:57:49 +02:00
2013-09-26 12:31:42 +03:00
2013-03-21 14:34:33 +02:00
2013-12-10 11:25:07 +11:00
2013-07-26 10:37:02 +03:00
2013-09-26 13:49:25 +03:00
2013-10-29 12:53:07 +02:00
2013-10-29 12:53:07 +02:00
2013-10-29 12:53:07 +02:00
2013-10-29 12:53:07 +02:00
2013-10-29 12:53:07 +02:00
2013-09-11 11:39:39 +10:00
2013-10-29 12:53:07 +02:00
2013-07-09 15:51:32 -07:00
2013-09-20 12:22:01 +03:00
2013-09-20 12:22:02 +03:00
2013-10-29 12:53:07 +02:00
2013-10-29 12:53:07 +02:00
2013-09-20 12:22:02 +03:00
2013-09-20 12:23:21 +03:00
2013-12-21 10:06:10 -07:00
2013-09-20 12:22:02 +03:00
2013-10-30 13:34:52 +02:00
2013-10-29 12:53:07 +02:00
2013-07-29 11:25:03 +03:00
2013-06-26 14:44:40 +03:00
2013-11-11 15:32:58 +02:00
2014-01-17 10:57:38 +02:00
2012-11-21 15:50:01 +01:00
2013-11-26 16:59:42 +02:00
2013-10-30 12:49:02 +02:00
2013-10-29 12:53:07 +02:00
2013-01-03 15:57:01 -08:00
2013-09-26 11:50:08 +03:00
2013-10-09 12:35:44 +03:00
2013-10-29 12:53:07 +02:00
2013-11-07 22:46:20 +01:00
2013-11-14 14:44:20 +09:00
2013-01-03 15:57:01 -08:00
2013-09-26 13:49:26 +03:00
2013-01-03 15:57:01 -08:00
2013-10-29 12:53:07 +02:00
2013-10-30 13:34:52 +02:00
2013-10-30 13:34:52 +02:00
2013-09-19 13:30:10 +03:00
2014-01-17 10:57:48 +02:00
2013-10-29 12:53:07 +02:00
2013-09-19 13:30:10 +03:00
2013-12-19 15:10:49 +01:00
2013-10-29 12:53:07 +02:00
2013-11-26 11:09:22 +01:00
2013-10-29 12:53:07 +02:00
2013-10-29 12:53:07 +02:00
2013-10-29 12:53:07 +02:00
2013-03-21 14:34:33 +02:00
2013-12-04 10:50:16 +02:00
2013-12-21 10:06:10 -07:00
2013-10-29 12:53:07 +02:00
2013-10-29 12:53:07 +02:00
2013-10-09 12:35:46 +03:00
2013-04-04 13:07:33 +03:00
2014-01-07 09:59:54 -05:00
2013-10-29 10:49:40 +02:00
00a9d699bc