mirror of
https://github.com/torvalds/linux.git
synced 2025-12-07 20:06:24 +00:00
syzbot reported that tcf_get_base_ptr() can be called while transport
header is not set [1].
Instead of returning a dangling pointer, return NULL.
Fix tcf_get_base_ptr() callers to handle this NULL value.
[1]
WARNING: CPU: 1 PID: 6019 at ./include/linux/skbuff.h:3071 skb_transport_header include/linux/skbuff.h:3071 [inline]
WARNING: CPU: 1 PID: 6019 at ./include/linux/skbuff.h:3071 tcf_get_base_ptr include/net/pkt_cls.h:539 [inline]
WARNING: CPU: 1 PID: 6019 at ./include/linux/skbuff.h:3071 em_nbyte_match+0x2d8/0x3f0 net/sched/em_nbyte.c:43
Modules linked in:
CPU: 1 UID: 0 PID: 6019 Comm: syz.0.17 Not tainted syzkaller #0 PREEMPT(full)
Call Trace:
<TASK>
tcf_em_match net/sched/ematch.c:494 [inline]
__tcf_em_tree_match+0x1ac/0x770 net/sched/ematch.c:520
tcf_em_tree_match include/net/pkt_cls.h:512 [inline]
basic_classify+0x115/0x2d0 net/sched/cls_basic.c:50
tc_classify include/net/tc_wrapper.h:197 [inline]
__tcf_classify net/sched/cls_api.c:1764 [inline]
tcf_classify+0x4cf/0x1140 net/sched/cls_api.c:1860
multiq_classify net/sched/sch_multiq.c:39 [inline]
multiq_enqueue+0xfd/0x4c0 net/sched/sch_multiq.c:66
dev_qdisc_enqueue+0x4e/0x260 net/core/dev.c:4118
__dev_xmit_skb net/core/dev.c:4214 [inline]
__dev_queue_xmit+0xe83/0x3b50 net/core/dev.c:4729
packet_snd net/packet/af_packet.c:3076 [inline]
packet_sendmsg+0x3e33/0x5080 net/packet/af_packet.c:3108
sock_sendmsg_nosec net/socket.c:727 [inline]
__sock_sendmsg+0x21c/0x270 net/socket.c:742
____sys_sendmsg+0x505/0x830 net/socket.c:2630
Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Reported-by: syzbot+f3a497f02c389d86ef16@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/netdev/6920855a.a70a0220.2ea503.0058.GAE@google.com/T/#u
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
Link: https://patch.msgid.link/20251121154100.1616228-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
164 lines
3.6 KiB
C
164 lines
3.6 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* net/sched/em_text.c Textsearch ematch
|
|
*
|
|
* Authors: Thomas Graf <tgraf@suug.ch>
|
|
*/
|
|
|
|
#include <linux/slab.h>
|
|
#include <linux/module.h>
|
|
#include <linux/types.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/string.h>
|
|
#include <linux/skbuff.h>
|
|
#include <linux/textsearch.h>
|
|
#include <linux/tc_ematch/tc_em_text.h>
|
|
#include <net/pkt_cls.h>
|
|
|
|
struct text_match {
|
|
u16 from_offset;
|
|
u16 to_offset;
|
|
u8 from_layer;
|
|
u8 to_layer;
|
|
struct ts_config *config;
|
|
};
|
|
|
|
#define EM_TEXT_PRIV(m) ((struct text_match *) (m)->data)
|
|
|
|
static int em_text_match(struct sk_buff *skb, struct tcf_ematch *m,
|
|
struct tcf_pkt_info *info)
|
|
{
|
|
struct text_match *tm = EM_TEXT_PRIV(m);
|
|
unsigned char *ptr;
|
|
int from, to;
|
|
|
|
ptr = tcf_get_base_ptr(skb, tm->from_layer);
|
|
if (!ptr)
|
|
return 0;
|
|
from = ptr - skb->data;
|
|
from += tm->from_offset;
|
|
|
|
ptr = tcf_get_base_ptr(skb, tm->to_layer);
|
|
if (!ptr)
|
|
return 0;
|
|
to = ptr - skb->data;
|
|
to += tm->to_offset;
|
|
|
|
return skb_find_text(skb, from, to, tm->config) != UINT_MAX;
|
|
}
|
|
|
|
static int em_text_change(struct net *net, void *data, int len,
|
|
struct tcf_ematch *m)
|
|
{
|
|
struct text_match *tm;
|
|
struct tcf_em_text *conf = data;
|
|
struct ts_config *ts_conf;
|
|
int flags = 0;
|
|
|
|
if (len < sizeof(*conf) || len < (sizeof(*conf) + conf->pattern_len))
|
|
return -EINVAL;
|
|
|
|
if (conf->from_layer > conf->to_layer)
|
|
return -EINVAL;
|
|
|
|
if (conf->from_layer == conf->to_layer &&
|
|
conf->from_offset > conf->to_offset)
|
|
return -EINVAL;
|
|
|
|
retry:
|
|
ts_conf = textsearch_prepare(conf->algo, (u8 *) conf + sizeof(*conf),
|
|
conf->pattern_len, GFP_KERNEL, flags);
|
|
|
|
if (flags & TS_AUTOLOAD)
|
|
rtnl_lock();
|
|
|
|
if (IS_ERR(ts_conf)) {
|
|
if (PTR_ERR(ts_conf) == -ENOENT && !(flags & TS_AUTOLOAD)) {
|
|
rtnl_unlock();
|
|
flags |= TS_AUTOLOAD;
|
|
goto retry;
|
|
} else
|
|
return PTR_ERR(ts_conf);
|
|
} else if (flags & TS_AUTOLOAD) {
|
|
textsearch_destroy(ts_conf);
|
|
return -EAGAIN;
|
|
}
|
|
|
|
tm = kmalloc(sizeof(*tm), GFP_KERNEL);
|
|
if (tm == NULL) {
|
|
textsearch_destroy(ts_conf);
|
|
return -ENOBUFS;
|
|
}
|
|
|
|
tm->from_offset = conf->from_offset;
|
|
tm->to_offset = conf->to_offset;
|
|
tm->from_layer = conf->from_layer;
|
|
tm->to_layer = conf->to_layer;
|
|
tm->config = ts_conf;
|
|
|
|
m->datalen = sizeof(*tm);
|
|
m->data = (unsigned long) tm;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void em_text_destroy(struct tcf_ematch *m)
|
|
{
|
|
if (EM_TEXT_PRIV(m) && EM_TEXT_PRIV(m)->config) {
|
|
textsearch_destroy(EM_TEXT_PRIV(m)->config);
|
|
kfree(EM_TEXT_PRIV(m));
|
|
}
|
|
}
|
|
|
|
static int em_text_dump(struct sk_buff *skb, struct tcf_ematch *m)
|
|
{
|
|
struct text_match *tm = EM_TEXT_PRIV(m);
|
|
struct tcf_em_text conf;
|
|
|
|
strscpy(conf.algo, tm->config->ops->name);
|
|
conf.from_offset = tm->from_offset;
|
|
conf.to_offset = tm->to_offset;
|
|
conf.from_layer = tm->from_layer;
|
|
conf.to_layer = tm->to_layer;
|
|
conf.pattern_len = textsearch_get_pattern_len(tm->config);
|
|
conf.pad = 0;
|
|
|
|
if (nla_put_nohdr(skb, sizeof(conf), &conf) < 0)
|
|
goto nla_put_failure;
|
|
if (nla_append(skb, conf.pattern_len,
|
|
textsearch_get_pattern(tm->config)) < 0)
|
|
goto nla_put_failure;
|
|
return 0;
|
|
|
|
nla_put_failure:
|
|
return -1;
|
|
}
|
|
|
|
static struct tcf_ematch_ops em_text_ops = {
|
|
.kind = TCF_EM_TEXT,
|
|
.change = em_text_change,
|
|
.match = em_text_match,
|
|
.destroy = em_text_destroy,
|
|
.dump = em_text_dump,
|
|
.owner = THIS_MODULE,
|
|
.link = LIST_HEAD_INIT(em_text_ops.link)
|
|
};
|
|
|
|
static int __init init_em_text(void)
|
|
{
|
|
return tcf_em_register(&em_text_ops);
|
|
}
|
|
|
|
static void __exit exit_em_text(void)
|
|
{
|
|
tcf_em_unregister(&em_text_ops);
|
|
}
|
|
|
|
MODULE_DESCRIPTION("ematch classifier for embedded text in skbs");
|
|
MODULE_LICENSE("GPL");
|
|
|
|
module_init(init_em_text);
|
|
module_exit(exit_em_text);
|
|
|
|
MODULE_ALIAS_TCF_EMATCH(TCF_EM_TEXT);
|