mirror of
https://github.com/torvalds/linux.git
synced 2025-12-07 20:06:24 +00:00
05954511b7
The ARM processor CPER record was added in UEFI v2.6 and remained unchanged up to v2.10. Yet, the original arm_event trace code added bye9279e83ad("trace, ras: add ARM processor error trace event") is incomplete, as it only traces some fields of UAPI 2.6 table N.16, not exporting any information from tables N.17 to N.29 of the record. This is not enough for the user to be able to figure out what has exactly happened or to take appropriate action. According to the UEFI v2.9 specification chapter N2.4.4, the ARM processor error section includes: - several (ERR_INFO_NUM) ARM processor error information structures (Tables N.17 to N.20); - several (CONTEXT_INFO_NUM) ARM processor context information structures (Tables N.21 to N.29); - several vendor specific error information structures. The size is given by Section Length minus the size of the other fields. In addition, it also exports two fields that are parsed by the GHES driver when firmware reports it, e.g.: - error severity - CPU logical index Report all of these information to userspace via a the ARM tracepoint so that userspace can properly record the error and take decisions related to CPU core isolation according to error severity and other info. The updated ARM trace event now contains the following fields: ====================================== ============================= UEFI field on table N.16 ARM Processor trace fields ====================================== ============================= Validation handled when filling data for affinity MPIDR and running state. ERR_INFO_NUM pei_len CONTEXT_INFO_NUM ctx_len Section Length indirectly reported by pei_len, ctx_len and oem_len Error affinity level affinity MPIDR_EL1 mpidr MIDR_EL1 midr Running State running_state PSCI State psci_state Processor Error Information Structure pei_err - count at pei_len Processor Context ctx_err- count at ctx_len Vendor Specific Error Info oem - count at oem_len ====================================== ============================= It should be noted that decoding of tables N.17 to N.29, if needed, will be handled in userspace. That gives more flexibility, as there won't be any need to flood the kernel with micro-architecture specific error decoding. Also, decoding the other fields require a complex logic, and should be done for each of the several values inside the record field. So, let userspace daemons like rasdaemon decode them, parsing such tables and having vendor-specific micro-architecture-specific decoders. [mchehab: modified description, solved merge conflicts and fixed coding style] Signed-off-by: Jason Tian <jason@os.amperecomputing.com> Co-developed-by: Shengwei Luo <luoshengwei@huawei.com> Signed-off-by: Shengwei Luo <luoshengwei@huawei.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Signed-off-by: Daniel Ferguson <danielf@os.amperecomputing.com> # rebased Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Tested-by: Shiju Jose <shiju.jose@huawei.com> Acked-by: Borislav Petkov (AMD) <bp@alien8.de> Fixes:e9279e83ad("trace, ras: add ARM processor error trace event") Link: https://uefi.org/specs/UEFI/2.10/Apx_N_Common_Platform_Error_Record.html#arm-processor-error-section Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
124 lines
3.1 KiB
C
124 lines
3.1 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (C) 2014 Intel Corporation
|
|
*
|
|
* Authors:
|
|
* Chen, Gong <gong.chen@linux.intel.com>
|
|
*/
|
|
|
|
#include <linux/init.h>
|
|
#include <linux/ras.h>
|
|
#include <linux/uuid.h>
|
|
|
|
#if IS_ENABLED(CONFIG_AMD_ATL)
|
|
/*
|
|
* Once set, this function pointer should never be unset.
|
|
*
|
|
* The library module will set this pointer if it successfully loads. The module
|
|
* should not be unloaded except for testing and debug purposes.
|
|
*/
|
|
static unsigned long (*amd_atl_umc_na_to_spa)(struct atl_err *err);
|
|
|
|
void amd_atl_register_decoder(unsigned long (*f)(struct atl_err *))
|
|
{
|
|
amd_atl_umc_na_to_spa = f;
|
|
}
|
|
EXPORT_SYMBOL_GPL(amd_atl_register_decoder);
|
|
|
|
void amd_atl_unregister_decoder(void)
|
|
{
|
|
amd_atl_umc_na_to_spa = NULL;
|
|
}
|
|
EXPORT_SYMBOL_GPL(amd_atl_unregister_decoder);
|
|
|
|
unsigned long amd_convert_umc_mca_addr_to_sys_addr(struct atl_err *err)
|
|
{
|
|
if (!amd_atl_umc_na_to_spa)
|
|
return -EINVAL;
|
|
|
|
return amd_atl_umc_na_to_spa(err);
|
|
}
|
|
EXPORT_SYMBOL_GPL(amd_convert_umc_mca_addr_to_sys_addr);
|
|
#endif /* CONFIG_AMD_ATL */
|
|
|
|
#define CREATE_TRACE_POINTS
|
|
#define TRACE_INCLUDE_PATH ../../include/ras
|
|
#include <ras/ras_event.h>
|
|
|
|
void log_non_standard_event(const guid_t *sec_type, const guid_t *fru_id,
|
|
const char *fru_text, const u8 sev, const u8 *err,
|
|
const u32 len)
|
|
{
|
|
trace_non_standard_event(sec_type, fru_id, fru_text, sev, err, len);
|
|
}
|
|
EXPORT_SYMBOL_GPL(log_non_standard_event);
|
|
|
|
void log_arm_hw_error(struct cper_sec_proc_arm *err, const u8 sev)
|
|
{
|
|
struct cper_arm_err_info *err_info;
|
|
struct cper_arm_ctx_info *ctx_info;
|
|
u8 *ven_err_data;
|
|
u32 ctx_len = 0;
|
|
int n, sz, cpu;
|
|
s32 vsei_len;
|
|
u32 pei_len;
|
|
u8 *pei_err, *ctx_err;
|
|
|
|
pei_len = sizeof(struct cper_arm_err_info) * err->err_info_num;
|
|
pei_err = (u8 *)(err + 1);
|
|
|
|
err_info = (struct cper_arm_err_info *)(err + 1);
|
|
ctx_info = (struct cper_arm_ctx_info *)(err_info + err->err_info_num);
|
|
ctx_err = (u8 *)ctx_info;
|
|
|
|
for (n = 0; n < err->context_info_num; n++) {
|
|
sz = sizeof(struct cper_arm_ctx_info) + ctx_info->size;
|
|
ctx_info = (struct cper_arm_ctx_info *)((long)ctx_info + sz);
|
|
ctx_len += sz;
|
|
}
|
|
|
|
vsei_len = err->section_length - (sizeof(struct cper_sec_proc_arm) + pei_len + ctx_len);
|
|
if (vsei_len < 0) {
|
|
pr_warn(FW_BUG "section length: %d\n", err->section_length);
|
|
pr_warn(FW_BUG "section length is too small\n");
|
|
pr_warn(FW_BUG "firmware-generated error record is incorrect\n");
|
|
vsei_len = 0;
|
|
}
|
|
ven_err_data = (u8 *)ctx_info;
|
|
|
|
cpu = GET_LOGICAL_INDEX(err->mpidr);
|
|
if (cpu < 0)
|
|
cpu = -1;
|
|
|
|
trace_arm_event(err, pei_err, pei_len, ctx_err, ctx_len,
|
|
ven_err_data, (u32)vsei_len, sev, cpu);
|
|
}
|
|
|
|
static int __init ras_init(void)
|
|
{
|
|
int rc = 0;
|
|
|
|
ras_debugfs_init();
|
|
rc = ras_add_daemon_trace();
|
|
|
|
return rc;
|
|
}
|
|
subsys_initcall(ras_init);
|
|
|
|
#if defined(CONFIG_ACPI_EXTLOG) || defined(CONFIG_ACPI_EXTLOG_MODULE)
|
|
EXPORT_TRACEPOINT_SYMBOL_GPL(extlog_mem_event);
|
|
#endif
|
|
EXPORT_TRACEPOINT_SYMBOL_GPL(mc_event);
|
|
EXPORT_TRACEPOINT_SYMBOL_GPL(non_standard_event);
|
|
EXPORT_TRACEPOINT_SYMBOL_GPL(arm_event);
|
|
|
|
static int __init parse_ras_param(char *str)
|
|
{
|
|
#ifdef CONFIG_RAS_CEC
|
|
parse_cec_param(str);
|
|
#endif
|
|
|
|
return 1;
|
|
}
|
|
__setup("ras", parse_ras_param);
|