Thorsten Blum
ad5f82ab04
ALSA: pcmtest: Replace deprecated strcpy with strscpy_pad in setup_patt_bufs
...
strcpy() has been deprecated [1] because it performs no bounds checking
on the destination buffer, which can lead to buffer overflows. Replace
it with the safer strscpy_pad(), and use kmalloc() instead of kzalloc()
because strscpy_pad() zero-pads the destination buffer and therefore
avoids writing to it twice.
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1]
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev >
Link: https://patch.msgid.link/20251119135217.233084-1-thorsten.blum@linux.dev
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2025-11-19 17:16:49 +01:00
John Keeping
8497324901
ALSA: serial-generic: remove shared static buffer
...
If multiple instances of this driver are instantiated and try to send
concurrently then the single static buffer snd_serial_generic_tx_work()
will cause corruption in the data output.
Move the buffer into the per-instance driver data to avoid this.
Signed-off-by: John Keeping <jkeeping@inmusicbrands.com >
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2025-09-15 12:33:53 +02:00
Takashi Iwai
b9526bff42
ALSA: serial-u16550: Use guard() for spin locks
...
Clean up the code using guard() for spin locks.
Merely code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250829150026.6379-14-tiwai@suse.de
2025-09-01 13:53:35 +02:00
Takashi Iwai
ec339e149e
ALSA: portman2x4: Use guard() for spin locks
...
Clean up the code using guard() for spin locks.
Merely code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250829150026.6379-13-tiwai@suse.de
2025-09-01 13:53:35 +02:00
Takashi Iwai
a28d65886b
ALSA: mts64: Use guard() for spin locks
...
Clean up the code using guard() for spin locks.
Merely code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250829150026.6379-12-tiwai@suse.de
2025-09-01 13:53:35 +02:00
Takashi Iwai
316e0074ec
ALSA: mtpav: Use guard() for spin locks
...
Clean up the code using guard() for spin locks.
Merely code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250829150026.6379-11-tiwai@suse.de
2025-09-01 13:53:35 +02:00
Takashi Iwai
55c52cd311
ALSA: mpu401: Use guard() for spin locks
...
Clean up the code using guard() for spin locks.
Merely code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250829150026.6379-10-tiwai@suse.de
2025-09-01 13:53:34 +02:00
Takashi Iwai
638c33ef79
ALSA: dummy: Use guard() for spin locks
...
Clean up the code using guard() for spin locks.
Merely code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250829150026.6379-9-tiwai@suse.de
2025-09-01 13:53:34 +02:00
Takashi Iwai
353fc3e381
ALSA: vx: Use guard() for mutex locks
...
Replace the manual mutex lock/unlock pairs with guard() for code
simplification.
Only code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250829150026.6379-8-tiwai@suse.de
2025-09-01 13:53:34 +02:00
Takashi Iwai
72a3017077
ALSA: opl4: Use guard() for spin locks
...
Clean up the code using guard() for spin locks.
Merely code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250829150026.6379-7-tiwai@suse.de
2025-09-01 13:53:34 +02:00
Takashi Iwai
45451eb5d1
ALSA: opl4: Use guard() for mutex locks
...
Replace the manual mutex lock/unlock pairs with guard() for code
simplification.
Only code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250829150026.6379-6-tiwai@suse.de
2025-09-01 13:53:34 +02:00
Takashi Iwai
ec6ac1d5e1
ALSA: opl3: Use guard() for spin locks
...
Clean up the code using guard() for spin locks.
Merely code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250829150026.6379-5-tiwai@suse.de
2025-09-01 13:53:34 +02:00
Takashi Iwai
6a6da5ca97
ALSA: opl3: Use guard() for mutex locks
...
Replace the manual mutex lock/unlock pairs with guard() for code
simplification.
Only code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250829150026.6379-4-tiwai@suse.de
2025-09-01 13:53:34 +02:00
Takashi Iwai
1ef2cb6b29
ALSA: aloop: Use guard() for spin locks
...
Clean up the code using guard() for spin locks.
Merely code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250829150026.6379-3-tiwai@suse.de
2025-09-01 13:53:34 +02:00
Takashi Iwai
ebd9b6c91d
ALSA: aloop: Use guard() for mutex locks
...
Replace the manual mutex lock/unlock pairs with guard() for code
simplification.
Only code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250829150026.6379-2-tiwai@suse.de
2025-09-01 13:53:33 +02:00
Takashi Iwai
c4a38b94ba
ALSA: vx: Use safer strscpy() instead of strcpy()
...
Use a safer function strscpy() instead of strcpy() for copying to
arrays.
Only idiomatic code replacement, and no functional changes.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250710100727.22653-13-tiwai@suse.de
2025-07-11 09:51:09 +02:00
Takashi Iwai
73e86d3666
ALSA: virmidi: Use safer strscpy() instead of strcpy()
...
Use a safer function strscpy() instead of strcpy() for copying to
arrays.
Only idiomatic code replacement, and no functional changes.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250710100727.22653-12-tiwai@suse.de
2025-07-11 09:51:09 +02:00
Takashi Iwai
a725f6fa58
ALSA: serial-u16550: Use safer strscpy() instead of strcpy()
...
Use a safer function strscpy() instead of strcpy() for copying to
arrays.
Only idiomatic code replacement, and no functional changes.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250710100727.22653-11-tiwai@suse.de
2025-07-11 09:51:09 +02:00
Takashi Iwai
eb264bc529
ALSA: serial-generic: Use safer strscpy() instead of strcpy()
...
Use a safer function strscpy() instead of strcpy() for copying to
arrays.
Only idiomatic code replacement, and no functional changes.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250710100727.22653-10-tiwai@suse.de
2025-07-11 09:51:09 +02:00
Takashi Iwai
7ba740ecf5
ALSA: portman2x4: Use safer strscpy() instead of strcpy()
...
Use a safer function strscpy() instead of strcpy() for copying to
arrays.
Only idiomatic code replacement, and no functional changes.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250710100727.22653-9-tiwai@suse.de
2025-07-11 09:51:09 +02:00
Takashi Iwai
6d352251e9
ALSA: pcsp: Use safer strscpy() instead of strcpy()
...
Use a safer function strscpy() instead of strcpy() for copying to
arrays.
Only idiomatic code replacement, and no functional changes.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250710100727.22653-8-tiwai@suse.de
2025-07-11 09:51:09 +02:00
Takashi Iwai
0676ccf26f
ALSA: opl4: Use safer strscpy() instead of strcpy()
...
Use a safer function strscpy() instead of strcpy() for copying to
arrays.
Only idiomatic code replacement, and no functional changes.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250710100727.22653-7-tiwai@suse.de
2025-07-11 09:51:08 +02:00
Takashi Iwai
bb246ab094
ALSA: opl3: Use safer strscpy() instead of strcpy()
...
Use a safer function strscpy() instead of strcpy() for copying to
arrays.
Only idiomatic code replacement, and no functional changes.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250710100727.22653-6-tiwai@suse.de
2025-07-11 09:51:08 +02:00
Takashi Iwai
59cea894bf
ALSA: mpu401: Use safer strscpy() instead of strcpy()
...
Use a safer function strscpy() instead of strcpy() for copying to
arrays.
Only idiomatic code replacement, and no functional changes.
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20250710100727.22653-5-tiwai@suse.de
2025-07-11 09:51:08 +02:00
Thorsten Blum
3263a554f3
ALSA: mts64: Replace deprecated strcpy() with strscpy()
...
strcpy() is deprecated; use strscpy() instead.
No functional changes intended.
Link: https://github.com/KSPP/linux/issues/88
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev >
Link: https://patch.msgid.link/20250706160906.416270-1-thorsten.blum@linux.dev
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2025-07-07 09:57:09 +02:00
Thorsten Blum
72a600a27f
ALSA: mtpav: Replace deprecated strcpy() with strscpy()
...
strcpy() is deprecated; use strscpy() instead.
No functional changes intended.
Link: https://github.com/KSPP/linux/issues/88
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev >
Link: https://patch.msgid.link/20250703134255.3948-2-thorsten.blum@linux.dev
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2025-07-04 09:04:41 +02:00
Thorsten Blum
30cd599619
ALSA: pcmtest: Replace deprecated strcpy() with strscpy()
...
strcpy() is deprecated; use strscpy() instead.
No functional changes intended.
Link: https://github.com/KSPP/linux/issues/88
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev >
Link: https://patch.msgid.link/20250701120525.185831-2-thorsten.blum@linux.dev
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2025-07-02 16:27:49 +02:00
Thorsten Blum
66b338d006
ALSA: dummy: Replace deprecated strcpy() with strscpy()
...
strcpy() is deprecated; use strscpy() instead.
No functional changes intended.
Link: https://github.com/KSPP/linux/issues/88
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev >
Link: https://patch.msgid.link/20250630110945.2225-2-thorsten.blum@linux.dev
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2025-06-30 14:08:32 +02:00
Thorsten Blum
962297a7cd
ALSA: aloop: Replace deprecated strcpy() with strscpy()
...
strcpy() is deprecated; use strscpy() instead.
No functional changes intended.
Link: https://github.com/KSPP/linux/issues/88
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev >
Link: https://patch.msgid.link/20250618223844.1458-2-thorsten.blum@linux.dev
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2025-06-20 10:06:27 +02:00
Ingo Molnar
41cb08555c
treewide, timers: Rename from_timer() to timer_container_of()
...
Move this API to the canonical timer_*() namespace.
[ tglx: Redone against pre rc1 ]
Signed-off-by: Ingo Molnar <mingo@kernel.org >
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Link: https://lore.kernel.org/all/aB2X0jCKQO56WdMt@gmail.com
2025-06-08 09:07:37 +02:00
Thomas Gleixner
8fa7292fee
treewide: Switch/rename to timer_delete[_sync]()
...
timer_delete[_sync]() replaces del_timer[_sync](). Convert the whole tree
over and remove the historical wrapper inlines.
Conversion was done with coccinelle plus manual fixups where necessary.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Signed-off-by: Ingo Molnar <mingo@kernel.org >
2025-04-05 10:30:12 +02:00
Nam Cao
70e90680c2
ALSA: Switch to use hrtimer_setup()
...
hrtimer_setup() takes the callback function pointer as argument and
initializes the timer completely.
Replace hrtimer_init() and the open coded initialization of
hrtimer::function with the new setup mechanism.
Patch was created by using Coccinelle.
Acked-by: Zack Rusin <zack.rusin@broadcom.com >
Signed-off-by: Nam Cao <namcao@linutronix.de >
Cc: Takashi Iwai <tiwai@suse.com >
Link: https://patch.msgid.link/598031332ce738c82286a158cb66eb7e735b2e79.1738746904.git.namcao@linutronix.de
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2025-02-10 09:26:31 +01:00
Uwe Kleine-König
e3fc2fd77c
sound: Switch back to struct platform_driver::remove()
...
After commit 0edb555a65 ("platform: Make platform_driver::remove()
return void") .remove() is (again) the right callback to implement for
platform drivers.
Convert all platform drivers below sound to use .remove(), with
the eventual goal to drop struct platform_driver::remove_new(). As
.remove() and .remove_new() have the same prototypes, conversion is done
by just changing the structure member name in the driver initializer.
On the way do a few whitespace changes to make indention consistent.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com >
Link: https://patch.msgid.link/20241029073748.508077-2-u.kleine-koenig@baylibre.com
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2024-10-30 14:47:59 +01:00
Ivan Orlov
e949df0b02
ALSA: aloop: Allow using global timers
...
Allow using global timers as a timer source when card id is equal to -1
in the timer_source parameter.
Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com >
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20240813120701.171743-2-ivan.orlov0322@gmail.com
2024-08-18 09:55:54 +02:00
Takashi Iwai
9cbe416b93
ALSA: pcsp: Use standard print API
...
Use the standard print API with dev_*() instead of the old house-baked
one. It gives better information and allows dynamically control of
debug prints.
Reviewed-by: Jaroslav Kysela <perex@perex.cz >
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20240807133452.9424-15-tiwai@suse.de
2024-08-08 07:47:23 +02:00
Takashi Iwai
650dcf25e1
ALSA: dummy: Use standard print API
...
Use pr_*() macro instead of open-coded printk() just for code
simplification.
Reviewed-by: Jaroslav Kysela <perex@perex.cz >
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20240807133452.9424-14-tiwai@suse.de
2024-08-08 07:47:23 +02:00
Takashi Iwai
ca2f73ffaa
ALSA: aloop: Use standard print API
...
Use pr_err() instead of open-coded printk() just for code
simplification.
Reviewed-by: Jaroslav Kysela <perex@perex.cz >
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20240807133452.9424-13-tiwai@suse.de
2024-08-08 07:47:23 +02:00
Takashi Iwai
41abc8056d
ALSA: vx_core: Use standard print API
...
Use the standard print API with dev_*() instead of the old house-baked
one. It gives better information and allows dynamically control of
debug prints.
The commented old debug prints are dropped, too.
Reviewed-by: Jaroslav Kysela <perex@perex.cz >
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20240807133452.9424-12-tiwai@suse.de
2024-08-08 07:47:23 +02:00
Takashi Iwai
b426b3ba9f
ALSA: vx_core: Drop unused dev field
...
The vx_core.dev field has never been set but referred incorrectly at
firmware loading. Pass the proper device pointer from card->dev at
request_firmware(), and drop the unused dev field from vx_core, too.
Reviewed-by: Jaroslav Kysela <perex@perex.cz >
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20240807133452.9424-11-tiwai@suse.de
2024-08-08 07:47:23 +02:00
Takashi Iwai
b5557ef985
ALSA: virmidi: Use standard print API
...
Use the standard print API with dev_*() instead of the old house-baked
one. It gives better information and allows dynamically control of
debug prints.
Reviewed-by: Jaroslav Kysela <perex@perex.cz >
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20240807133452.9424-10-tiwai@suse.de
2024-08-08 07:47:23 +02:00
Takashi Iwai
4d82bf10d1
ALSA: serial-u16550: Use standard print API
...
Use the standard print API with dev_*() instead of the old house-baked
one. It gives better information and allows dynamically control of
debug prints.
Reviewed-by: Jaroslav Kysela <perex@perex.cz >
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20240807133452.9424-9-tiwai@suse.de
2024-08-08 07:47:23 +02:00
Takashi Iwai
7debf0350e
ALSA: opl4: Use standard print API
...
Use the standard print API with dev_*() instead of the old house-baked
one. It gives better information and allows dynamically control of
debug prints.
Reviewed-by: Jaroslav Kysela <perex@perex.cz >
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20240807133452.9424-8-tiwai@suse.de
2024-08-08 07:47:23 +02:00
Takashi Iwai
a2fa882d6d
ALSA: opl3: Use standard print API
...
Use the standard print API with dev_*() instead of the old house-baked
one. It gives better information and allows dynamically control of
debug prints.
Some debug prints are cleaned up with a macro, too.
Reviewed-by: Jaroslav Kysela <perex@perex.cz >
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20240807133452.9424-7-tiwai@suse.de
2024-08-08 07:47:22 +02:00
Takashi Iwai
1e594f9a7b
ALSA: mtpav: Use standard print API
...
Use the standard print API with dev_*() instead of the old house-baked
one. It gives better information and allows dynamically control of
debug prints.
The commented-out debug prints got removed, too.
Reviewed-by: Jaroslav Kysela <perex@perex.cz >
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20240807133452.9424-6-tiwai@suse.de
2024-08-08 07:47:22 +02:00
Takashi Iwai
1fa884ebeb
ALSA: mpu401_uart: Use standard print API
...
Use the standard print API with dev_*() instead of the old house-baked
one. It gives better information and allows dynamically control of
debug prints.
The assignment of mpu->rmidi was moved to an earlier place, so that
dev_*() can access to the proper device pointer.
Reviewed-by: Jaroslav Kysela <perex@perex.cz >
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20240807133452.9424-5-tiwai@suse.de
2024-08-08 07:47:22 +02:00
Takashi Iwai
2bddeda8ac
ALSA: mpu401: Use standard print API
...
Use the standard print API with dev_*() instead of the old house-baked
one. It gives better information and allows dynamically control of
debug prints.
Reviewed-by: Jaroslav Kysela <perex@perex.cz >
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20240807133452.9424-4-tiwai@suse.de
2024-08-08 07:47:22 +02:00
Takashi Iwai
f7d4adacc5
ALSA: mts64: Use standard print API
...
Use the standard print API with dev_*() instead of the old house-baked
one. It gives better information and allows dynamically control of
debug prints.
Reviewed-by: Jaroslav Kysela <perex@perex.cz >
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20240807133452.9424-3-tiwai@suse.de
2024-08-08 07:47:22 +02:00
Takashi Iwai
94cd66f8dc
ALSA: portman2x4: Use standard print API
...
Use the standard print API with dev_*() instead of the old house-baked
one. It gives better information and allows dynamically control of
debug prints.
Reviewed-by: Jaroslav Kysela <perex@perex.cz >
Signed-off-by: Takashi Iwai <tiwai@suse.de >
Link: https://patch.msgid.link/20240807133452.9424-2-tiwai@suse.de
2024-08-08 07:47:22 +02:00
Kuninori Morimoto
e1a642aba4
ALSA: aloop: use snd_pcm_direction_name()
...
We already have snd_pcm_direction_name(). Let's use it.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com >
Link: https://patch.msgid.link/87r0bbk528.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Takashi Iwai <tiwai@suse.de >
2024-08-01 12:50:08 +02:00
Dr. David Alan Gilbert
dfd19866d1
parport: Remove parport_driver.devmodel
...
'devmodel' hasn't actually been used since:
'commit 3275158fa5 ("parport: remove use of devmodel")'
and everyone now has it set to true and has been fixed up; remove
the flag.
(There are still comments all over about it)
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org >
Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com >
Link: https://lore.kernel.org/r/20240502154823.67235-4-linux@treblig.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2024-07-03 16:44:22 +02:00