mirror of
https://github.com/torvalds/linux.git
synced 2025-12-07 20:06:24 +00:00
scsi: ufs: sysfs: Make HID attributes visible
Call sysfs_update_group() after reading the device descriptor to ensure
the HID sysfs attributes are visible when the feature is supported.
Fixes: ae7795a8c2 ("scsi: ufs: core: Add HID support")
Signed-off-by: Daniel Lee <chullee@google.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
committed by
Martin K. Petersen
parent
60cd16a3b7
commit
bb7663dec6
@@ -1949,7 +1949,7 @@ static umode_t ufs_sysfs_hid_is_visible(struct kobject *kobj,
|
||||
return hba->dev_info.hid_sup ? attr->mode : 0;
|
||||
}
|
||||
|
||||
static const struct attribute_group ufs_sysfs_hid_group = {
|
||||
const struct attribute_group ufs_sysfs_hid_group = {
|
||||
.name = "hid",
|
||||
.attrs = ufs_sysfs_hid,
|
||||
.is_visible = ufs_sysfs_hid_is_visible,
|
||||
|
||||
@@ -14,5 +14,6 @@ void ufs_sysfs_remove_nodes(struct device *dev);
|
||||
|
||||
extern const struct attribute_group ufs_sysfs_unit_descriptor_group;
|
||||
extern const struct attribute_group ufs_sysfs_lun_attributes_group;
|
||||
extern const struct attribute_group ufs_sysfs_hid_group;
|
||||
|
||||
#endif
|
||||
|
||||
@@ -8480,6 +8480,8 @@ static int ufs_get_device_desc(struct ufs_hba *hba)
|
||||
DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP) &
|
||||
UFS_DEV_HID_SUPPORT;
|
||||
|
||||
sysfs_update_group(&hba->dev->kobj, &ufs_sysfs_hid_group);
|
||||
|
||||
model_index = desc_buf[DEVICE_DESC_PARAM_PRDCT_NAME];
|
||||
|
||||
err = ufshcd_read_string_desc(hba, model_index,
|
||||
|
||||
Reference in New Issue
Block a user