admin/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-12-07 20:06:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

drm/imx/ipuv3: Compute dumb-buffer sizes with drm_mode_size_dumb()

Browse Source 
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and
buffer size. The hardware requires the framebuffer width to be a
multiple of 8. The scanline pitch has to be large enough to support
this. Therefore compute the byte size of 8 pixels in the given color
mode and align the pitch accordingly.

v5:
- fix typo in commit description

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Link: https://lore.kernel.org/r/20250821081918.79786-11-tzimmermann@suse.de
This commit is contained in:
Thomas Zimmermann
2025-08-21 10:17:17 +02:00
parent ecf29357b6
commit b1d0e470f8
1 changed files with 23 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
drivers/gpu/drm/imx/ipuv3/imx-drm-core.c
View File

@@ -17,7 +17,9 @@
#include <drm/drm_atomic.h> #include <drm/drm_atomic.h>
#include <drm/drm_atomic_helper.h> #include <drm/drm_atomic_helper.h>
#include <drm/drm_drv.h> #include <drm/drm_drv.h>
#include <drm/drm_dumb_buffers.h>
#include <drm/drm_fbdev_dma.h> #include <drm/drm_fbdev_dma.h>
#include <drm/drm_fourcc.h>
#include <drm/drm_gem_dma_helper.h> #include <drm/drm_gem_dma_helper.h>
#include <drm/drm_gem_framebuffer_helper.h> #include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drm_managed.h> #include <drm/drm_managed.h>
@@ -141,19 +143,32 @@ static int imx_drm_dumb_create(struct drm_file *file_priv,
struct drm_device *drm, struct drm_device *drm,
struct drm_mode_create_dumb *args) struct drm_mode_create_dumb *args)
{ {
u32 width = args->width; u32 fourcc;
const struct drm_format_info *info;
u64 pitch_align;
int ret; int ret;
args->width = ALIGN(width, 8); /*
args->pitch = DIV_ROUND_UP(args->width * args->bpp, 8); * Hardware requires the framebuffer width to be aligned to
args->size = args->pitch * args->height; * multiples of 8. The mode-setting code handles this, but
* the buffer pitch has to be aligned as well. Set the pitch
ret = drm_gem_dma_dumb_create_internal(file_priv, drm, args); * alignment accordingly, so that the each scanline fits into
* the allocated buffer.
*/
fourcc = drm_driver_color_mode_format(drm, args->bpp);
if (fourcc == DRM_FORMAT_INVALID)
return -EINVAL;
info = drm_format_info(fourcc);
if (!info)
return -EINVAL;
pitch_align = drm_format_info_min_pitch(info, 0, SZ_8);
if (!pitch_align || pitch_align > U32_MAX)
return -EINVAL;
ret = drm_mode_size_dumb(drm, args, pitch_align, 0);
if (ret) if (ret)
return ret; return ret;
args->width = width; return drm_gem_dma_dumb_create(file_priv, drm, args);
return ret;
} }
static const struct drm_driver imx_drm_driver = { static const struct drm_driver imx_drm_driver = {