admin/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-12-07 20:06:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

seqlock: Cure some more scoped_seqlock() optimization fails

Browse Source 
Arnd reported an x86 randconfig using gcc-15 tripped over
__scoped_seqlock_bug(). Turns out GCC chose not to inline the
scoped_seqlock helper functions and as such was not able to optimize
properly.

[ mingo: Clang fails the build too in some circumstances. ]

Reported-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Link: https://patch.msgid.link/20251204104332.GG2528459@noisy.programming.kicks-ass.net
This commit is contained in:
Peter Zijlstra
2025-12-04 11:43:32 +01:00
committed by Ingo Molnar
parent 24bc5ea5c0
commit 90dfeef1cd
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/linux/seqlock.h
View File

@@ -1224,7 +1224,7 @@ struct ss_tmp {
spinlock_t *lock_irqsave; spinlock_t *lock_irqsave;
}; };
static inline void __scoped_seqlock_cleanup(struct ss_tmp *sst) static __always_inline void __scoped_seqlock_cleanup(struct ss_tmp *sst)
{ {
if (sst->lock) if (sst->lock)
spin_unlock(sst->lock); spin_unlock(sst->lock);
@@ -1252,7 +1252,7 @@ static inline void __scoped_seqlock_bug(void) { }
extern void __scoped_seqlock_bug(void); extern void __scoped_seqlock_bug(void);
#endif #endif
static inline void static __always_inline void
__scoped_seqlock_next(struct ss_tmp *sst, seqlock_t *lock, enum ss_state target) __scoped_seqlock_next(struct ss_tmp *sst, seqlock_t *lock, enum ss_state target)
{ {
switch (sst->state) { switch (sst->state) {