admin/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-12-07 20:06:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

bcachefs: Don't aggressively discard the journal

Browse Source 
We frequently use 'bcachefs list_journal -a' for debugging, as it
provides a record of all btree transactions, and a history of what
happened.

But it's not so useful if we immediately discard journal buckets right
after they're no longer dirty.

This tweaks journal reclaim to only discard when we're low on space,
keeping the journal mostly un-discarded.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
This commit is contained in:
Kent Overstreet
2025-05-07 13:32:15 -04:00
parent da18dabc37
commit 8e4d28036c
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
fs/bcachefs/journal_reclaim.c
View File

@@ -266,10 +266,11 @@ out:
static bool should_discard_bucket(struct journal *j, struct journal_device *ja)
{
bool ret;
spin_lock(&j->lock);
ret = ja->discard_idx != ja->dirty_idx_ondisk;
unsigned min_free = max(4, ja->nr / 8);
bool ret = bch2_journal_dev_buckets_available(j, ja, journal_space_discarded) < min_free &&
ja->discard_idx != ja->dirty_idx_ondisk;
spin_unlock(&j->lock);
return ret;