admin/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-12-07 20:06:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

media: imx335: Fix active area height discrepency

Browse Source 
The imx335 reports a recommended pixel area of - 2592x1944.
The driver supported mode however limits it to height=1940.

Fix the height discrepency by correctly the value of height
(with updates to vblank and mode registers).

The IMX335_REG_HTRIMMING should also be corrected to the start
offset(i.e. 48) instead of chosing a abritrary crop start of 384.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
This commit is contained in:
Umang Jain
2024-04-14 19:36:20 +05:30
committed by Hans Verkuil
parent 15a853bb1f
commit 81495a59ba
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/media/i2c/imx335.c
View File

@@ -255,9 +255,9 @@ static const struct cci_reg_sequence mode_2592x1940_regs[] = {
{ IMX335_REG_MODE_SELECT, IMX335_MODE_STANDBY }, { IMX335_REG_MODE_SELECT, IMX335_MODE_STANDBY },
{ IMX335_REG_MASTER_MODE, 0x00 }, { IMX335_REG_MASTER_MODE, 0x00 },
{ IMX335_REG_WINMODE, 0x04 }, { IMX335_REG_WINMODE, 0x04 },
{ IMX335_REG_HTRIMMING_START, 384 }, { IMX335_REG_HTRIMMING_START, 48 },
{ IMX335_REG_HNUM, 2592 }, { IMX335_REG_HNUM, 2592 },
{ IMX335_REG_Y_OUT_SIZE, 1940 }, { IMX335_REG_Y_OUT_SIZE, 1944 },
{ IMX335_REG_AREA3_ST_ADR_1, 176 }, { IMX335_REG_AREA3_ST_ADR_1, 176 },
{ IMX335_REG_AREA3_WIDTH_1, 3928 }, { IMX335_REG_AREA3_WIDTH_1, 3928 },
{ IMX335_REG_OPB_SIZE_V, 0 }, { IMX335_REG_OPB_SIZE_V, 0 },
@@ -408,10 +408,10 @@ static const u32 imx335_mbus_codes[] = {
/* Supported sensor mode configurations */ /* Supported sensor mode configurations */
static const struct imx335_mode supported_mode = { static const struct imx335_mode supported_mode = {
.width = 2592, .width = 2592,
.height = 1940, .height = 1944,
.hblank = 342, .hblank = 342,
.vblank = 2560, .vblank = 2556,
.vblank_min = 2560, .vblank_min = 2556,
.vblank_max = 133060, .vblank_max = 133060,
.pclk = 396000000, .pclk = 396000000,
.reg_list = { .reg_list = {