admin/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-12-07 20:06:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

drm/bridge: it66121: Add minimal it66122 support

Browse Source 
The IT66122 is a pin compatible replacement for the IT66122. Based on
empirical testing, the new device looks to be compatible with IT66121.
However due to a lack of public data sheet at this time beyond overall
feature list[1] (which seems to add additional features vs ITT66121),
it is hard to determine that additional register operations required
to enable additional features.

So, introduce the device as a new compatible that we will detect based
on vid/pid match, with explicit id that can be used to extend the
driver capability as information becomes available later on.

[1] https://www.ite.com.tw/en/product/cate1/IT66122

Signed-off-by: Nishanth Menon <nm@ti.com>
Reviewed-by: Andrew Davis <afd@ti.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patch.msgid.link/20251029150636.3118628-6-nm@ti.com
This commit is contained in:
Nishanth Menon
2025-10-29 10:06:36 -05:00
committed by Neil Armstrong
parent a8811c0bb7
commit 715cbb21c6
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/gpu/drm/bridge/ite-it66121.c
View File

@@ -287,6 +287,7 @@
enum chip_id { enum chip_id {
ID_IT6610, ID_IT6610,
ID_IT66121, ID_IT66121,
ID_IT66122,
}; };
struct it66121_chip_info { struct it66121_chip_info {
@@ -402,7 +403,7 @@ static int it66121_configure_afe(struct it66121_ctx *ctx,
if (ret) if (ret)
return ret; return ret;
if (ctx->id == ID_IT66121) { if (ctx->id == ID_IT66121 || ctx->id == ID_IT66122) {
ret = regmap_write_bits(ctx->regmap, IT66121_AFE_IP_REG, ret = regmap_write_bits(ctx->regmap, IT66121_AFE_IP_REG,
IT66121_AFE_IP_EC1, 0); IT66121_AFE_IP_EC1, 0);
if (ret) if (ret)
@@ -428,7 +429,7 @@ static int it66121_configure_afe(struct it66121_ctx *ctx,
if (ret) if (ret)
return ret; return ret;
if (ctx->id == ID_IT66121) { if (ctx->id == ID_IT66121 || ctx->id == ID_IT66122) {
ret = regmap_write_bits(ctx->regmap, IT66121_AFE_IP_REG, ret = regmap_write_bits(ctx->regmap, IT66121_AFE_IP_REG,
IT66121_AFE_IP_EC1, IT66121_AFE_IP_EC1,
IT66121_AFE_IP_EC1); IT66121_AFE_IP_EC1);
@@ -599,7 +600,7 @@ static int it66121_bridge_attach(struct drm_bridge *bridge,
if (ret) if (ret)
return ret; return ret;
if (ctx->id == ID_IT66121) { if (ctx->id == ID_IT66121 || ctx->id == ID_IT66122) {
ret = regmap_write_bits(ctx->regmap, IT66121_CLK_BANK_REG, ret = regmap_write_bits(ctx->regmap, IT66121_CLK_BANK_REG,
IT66121_CLK_BANK_PWROFF_RCLK, 0); IT66121_CLK_BANK_PWROFF_RCLK, 0);
if (ret) if (ret)
@@ -802,7 +803,7 @@ void it66121_bridge_mode_set(struct drm_bridge *bridge,
if (regmap_write(ctx->regmap, IT66121_HDMI_MODE_REG, IT66121_HDMI_MODE_HDMI)) if (regmap_write(ctx->regmap, IT66121_HDMI_MODE_REG, IT66121_HDMI_MODE_HDMI))
goto unlock; goto unlock;
if (ctx->id == ID_IT66121 && if ((ctx->id == ID_IT66121 || ctx->id == ID_IT66122) &&
regmap_write_bits(ctx->regmap, IT66121_CLK_BANK_REG, regmap_write_bits(ctx->regmap, IT66121_CLK_BANK_REG,
IT66121_CLK_BANK_PWROFF_TXCLK, IT66121_CLK_BANK_PWROFF_TXCLK,
IT66121_CLK_BANK_PWROFF_TXCLK)) { IT66121_CLK_BANK_PWROFF_TXCLK)) {
@@ -815,7 +816,7 @@ void it66121_bridge_mode_set(struct drm_bridge *bridge,
if (it66121_configure_afe(ctx, adjusted_mode)) if (it66121_configure_afe(ctx, adjusted_mode))
goto unlock; goto unlock;
if (ctx->id == ID_IT66121 && if ((ctx->id == ID_IT66121 || ctx->id == ID_IT66122) &&
regmap_write_bits(ctx->regmap, IT66121_CLK_BANK_REG, regmap_write_bits(ctx->regmap, IT66121_CLK_BANK_REG,
IT66121_CLK_BANK_PWROFF_TXCLK, 0)) { IT66121_CLK_BANK_PWROFF_TXCLK, 0)) {
goto unlock; goto unlock;
@@ -1501,6 +1502,7 @@ static const char * const it66121_supplies[] = {
static const struct it66121_chip_info it66xx_chip_info[] = { static const struct it66121_chip_info it66xx_chip_info[] = {
{.id = ID_IT6610, .vid = 0xca00, .pid = 0x0611 }, {.id = ID_IT6610, .vid = 0xca00, .pid = 0x0611 },
{.id = ID_IT66121, .vid = 0x4954, .pid = 0x0612 }, {.id = ID_IT66121, .vid = 0x4954, .pid = 0x0612 },
{.id = ID_IT66122, .vid = 0x4954, .pid = 0x0622 },
}; };
static int it66121_probe(struct i2c_client *client) static int it66121_probe(struct i2c_client *client)
@@ -1621,6 +1623,7 @@ static void it66121_remove(struct i2c_client *client)
static const struct of_device_id it66121_dt_match[] = { static const struct of_device_id it66121_dt_match[] = {
{ .compatible = "ite,it6610" }, { .compatible = "ite,it6610" },
{ .compatible = "ite,it66121" }, { .compatible = "ite,it66121" },
{ .compatible = "ite,it66122" },
{ } { }
}; };
MODULE_DEVICE_TABLE(of, it66121_dt_match); MODULE_DEVICE_TABLE(of, it66121_dt_match);
@@ -1628,6 +1631,7 @@ MODULE_DEVICE_TABLE(of, it66121_dt_match);
static const struct i2c_device_id it66121_id[] = { static const struct i2c_device_id it66121_id[] = {
{ .name = "it6610" }, { .name = "it6610" },
{ .name = "it66121" }, { .name = "it66121" },
{ .name = "it66122" },
{ } { }
}; };
MODULE_DEVICE_TABLE(i2c, it66121_id); MODULE_DEVICE_TABLE(i2c, it66121_id);